tag 367731 +patch
thanks
I have prepared a patch. I did not encounter any problems, the patch
seems straigtforward to me.
The only problem I was able to detect is, that when updating iptotal an
error is reported:
dpkg -i iptotal_0.3.3-6.1_amd64.deb
(Reading database ... 156305 files and directories currently installed.)
Preparing to replace iptotal 0.3.3-6 (using
iptotal_0.3.3-6.1_amd64.deb) ...
Stopping iptotal: iptotal.
Unpacking replacement iptotal ...
postrm called with unknown argument `upgrade'
dpkg: warning - old post-removal script returned error exit status 1
dpkg - trying script from the new package instead ...
dpkg: ... it looks like that went OK.
Setting up iptotal (0.3.3-6.1) ...
Starting iptotal: iptotal.
However, the error is non-fatal (actually I believe it is not really a
problem, just a missing empty case-block in the postrm script) and the
recovery mechanism works just fine. Also, it is not caused by the patch
but is in the current code base. Since it is not critical, I refrained
from fixing it.
If you see any problems with the patch, please let me know. Otherwise
you could prepare a new upload based on the fix or I could ask my AM to
sponsor an NMU.
Regards Ben
diff -ur iptotal-debian-orig/debian/postinst iptotal-0.3.3/debian/postinst
--- iptotal-debian-orig/debian/postinst 2007-08-28 19:16:35.000000000 +0200
+++ iptotal-0.3.3/debian/postinst 2007-08-28 18:46:42.000000000 +0200
@@ -20,8 +20,11 @@
case "$1" in
configure)
update-rc.d iptotal defaults >/dev/null
- /etc/init.d/iptotal start
-
+ if which invoke-rc.d >/dev/null 2>&1; then
+ invoke-rc.d iptotal start
+ else
+ /etc/init.d/iptotal start
+ fi
;;
abort-upgrade|abort-remove|abort-deconfigure)
diff -ur iptotal-debian-orig/debian/prerm iptotal-0.3.3/debian/prerm
--- iptotal-debian-orig/debian/prerm 2007-08-28 19:16:35.000000000 +0200
+++ iptotal-0.3.3/debian/prerm 2007-08-28 18:45:41.000000000 +0200
@@ -19,7 +19,11 @@
case "$1" in
remove|upgrade|deconfigure)
- /etc/init.d/iptotal stop
+ if which invoke-rc.d >/dev/null 2>&1; then
+ invoke-rc.d iptotal stop
+ else
+ /etc/init.d/iptotal stop
+ fi
;;
failed-upgrade)
;;
