On Tuesday 04 September 2007, you wrote: > Le mardi 04 septembre 2007 15:54, Frans Pop a écrit : > > Why was it decided to do this differently for Debian? Backwards > > compatibility with previous Debian versions maybe?
> Yes, 2 reasons: I've reversed your reasons for clarity of my arguments. > 2- directories in /etc should have the same name as the package > so /etc/backuppc is used and not /etc/BackupPC. I completely agree with this. We could try to convince upstream to change this, but if not it should be relatively trivial to maintain a patch for debian. The only disadvantage is that Debian users who read the upstream documentation may be slightly confused. Note that after my patch there is still some slightly confusing info in the documentation: ! Starting with BackupPC 3.0.0, the configure.pl script by default complies ! with the file system hierarchy conventions. The major difference compared ! to earlier versions is that by default configuration files will be ! stored in /etc/BackupPC rather than below the data directory, ! /var/lib/backuppc/conf, and the log files will be stored in ! /var/log/BackupPC. rather than below the data directory, ! /var/lib/backuppc/log. 1. s:/etc/BackupPC:/etc/backuppc: 2. For Debian the logfiles are still in /var/lib/backuppc/log. However, it could be argued that this para describes the default upstream configuration and not the Debianized configuration (but then it should really be 2 times s:/var/lib/backuppc/:/var/lib/BackupPC/:). Maybe a short para could be added to the beginning of "Step 2" that most of the info is irrelevant if you use a package from a distribution? Hmm. That could even be done upstream. Why did you not move the main log files under /var/log/? I can see that it would require some patching to leave the other files in that dir in their current location and also the compression and rotation are not really standard... There is also a problem with this bit: ! Config and Log directories ! In this installation the configuration and log directories are located ! in the following locations: ! /etc/backuppc/config.pl main config file ! /etc/backuppc/hosts hosts file ! /etc/backuppc/pc/HOST.pl per-pc config file ! /BackupPC log files, pid, status 1. The last line uses __LOGDIR__/BackupPC. Apparently __LOGDIR__ is not set. 2. The pid file is not in the same location as the other files. If you like I can work on patches for this chapter to solve/clarify these issues. > 1- the debian package 1st introduced the config files in /etc (before > they were found in /var/lib/backuppc) OK. However, now that upstream has made the switch, I wonder if it would not make sense to have the per-host config files in a ./pc/ subdir for Debian as well. The rationale would be: - reduce (unnecessary) differences with upstream - avoid clutter in /etc/backuppc so that the "main" configuration files remain more visible (especially with large number of hosts!) - theoretically allow for the existence of a host named "config" without conflicting with the general config.pl file (currently there are other issues in the code that will not allow that, but those could be fixed upstream) IMO it should be relatively easy to either - automatically move existing host config files to the ./pc/ subdir when they are first accessed - use ./pc/$host as default location, but fall back to ./$host if that does not exist and print a log message suggesting that they be moved, leaving it to the admin to do so If you like I can probably come up with a patch for the option you prefer. In both cases the change should of course be documented in README.Debian. Cheers, FJP P.S. I've already submitted a fairly invasive proposal upstream and I like BackupPC enough that I'm willing to spend some time on it.
signature.asc
Description: This is a digitally signed message part.
