On Mon, Sep 24, 2007 at 10:08:17PM +0000, Sergio Talens-Oliag wrote: > reopen 443871 > thanks
I did not closed the bug, I marked it wontfix. > El Mon, Sep 24, 2007 at 08:54:38PM +0200, Pierre Habouzit va escriure: > > On Mon, Sep 24, 2007 at 06:08:35PM +0000, Sergio Talens-Oliag wrote: > I accept that my patch is not good enough for your taste, and maybe a better > one or a different solution is a better option, but I disagree about your > argument about conffiles. It's not a matter of "not good enough" it's just brittle. My job is to provide a good sane default for 99% of the use of the software. I can't provide a perfect sane default for any use, so just make up your stuff if you need to. > Instead of simplifying the maintenance of the package you want me to modify > two configuration files (if I do a manual configuration that is normal) but I > also need to change and review on each upgrade two scripts that I would > normally asume that I don't need to touch (in Debian the use of > /etc/default/PACKAGE_NAME usually means that I don't need to touch the scripts > distributed under /etc). You don't need to touch the init.d script, only the one in /etc/resolvconf/update.d/pdnsd, so please, give me a break. For your own system, you can hardcode the thing in there if you want, the merge will be trivial. (especially since it's a one liner diff). > > I provide two reasonable usual setups, if yours differs, use "manual" > > setup, and do your config. I offer _rock solid_ configuration schemes, > > sorry, but your patch isn't. > > My patch is not _rock solid_, but I'm using a "manual" setup and when I do a > really simple change on the main configuration file the system breaks and I > need to change two additional scripts because you have hardcoded a value... I > would not call that _rock solid_, would you? > > Now the question is, would you accept a patch to support the use of a variable > in /etc/default/pdnsd to change the resolvconf server ip for manual setups? I don't like the fact that you have to duplicate configuration in many places. That should just be automatic. and editing /etc/default/pdnsd _and_ /etc/pdnsd.conf is not a good solution. People will never ever guess they need to do things like that. OTOH, why isn't 'any' or 0.0.0.0 suitable for you ? This way, using 127.0.0.1 still works... And if you want my opinion, the best fix is to patch pdnsd to be able to listen on multiple addresses... it's probably not _that_ hard. -- ·O· Pierre Habouzit ··O [EMAIL PROTECTED] OOO http://www.madism.org
pgpyC4UeGpRkf.pgp
Description: PGP signature