Jon Jensen wrote: > On Tue, 9 Oct 2007, Stefan Hornburg (Racke) wrote: > >> OK, the attached patch is experimental code in order to fix this problem. >> It has the following flaws right now: >> >> * works only with DBI databases >> * pragma needs to be set >> * confusing error message from DBI in the UI >> >> Any comments and suggestions for improvements ? > > Seems ok to me, but I wonder if a pragma is the right level to control > it from.
It just has the least impact on the current source code and works globally. > Does e.g. the table editor distinguish between insert and > update when creating a new row? Table editor sets mv_data_function to insert if ui_new_item is set, so this is my indicator to determine whether an updae is dangerous. > I thought it just called set_row > blindly, not caring whether the row existed already or not. > > I wonder if a table editor checkbox "Overwrite any existing record" or > some such would be appropriate. This adds more complexity then needed. Why not ask the user if he really likes to overwrite a record if the insert fails ? Regards Racke -- LinuXia Systems => http://www.linuxia.de/ Expert Interchange Consulting and System Administration ICDEVGROUP => http://www.icdevgroup.org/ Interchange Development Team -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]