* Andrei Popescu <[EMAIL PROTECTED]> [2007-09-09 20:24]:
> > Yes, that makes sense. I'm not sure whether FreeDB tagging can be
> > supported properly when you specify both query_on_start and
> > cont_failed_query. The problem is that jack thinks the query failed and
> > doesn't really know that you entered something manually. There's an
> > --edit-freedb option which you could also specify.
>
> The question still stands: why does the renaming work, but not the
> tagging?
I looked at this some more. When the query on start fails, jack sets
an internal variable to say that it should not tag files. There's
a different variable that says whether files should be renamed and
that's not changed. Your question is whether this behaviour makes
sense. After looking at the code, I don't think it does. When we
don't change that variable, nothing bad happens and the reason is
simlpy: if a value jack absolutely needs is missing from th FreeDB
file, it will print an error anyway and quit. So I don't think
there's a reason that jack doesn't tag files when the query on start
fails. After all, someone might have edited the file (as you did) and
if the data is really missing, jack will notice anyway and quit.
I should mention that I didn't write jack so I've no idea why jack is
doing what it does. The developer of jack is busy so I cannot ask
him. Based on my investigation, I think its safe to remove the code
which sets the internal variable not to tag files. I tested this here
and it works for me. I'd appreciate it if you could give it a go as
well. I believes it resolves all problems.
So I'm inclined to apply two patches. First, a patch to remove the
code mentioned above (it's only a line). Second, a patch to ask
people when query on start fails whether they want to edit the data.
Anyway, can you try this patch please:
--- /usr/share/python-support/jack/jack_prepare.py 2007-10-21
16:54:00.000000000 +0200
+++ /usr/share/python-support/jack/jack_prepare.py 2007-10-21
17:28:23.000000000 +0200
@@ -507,7 +507,6 @@
if not x or x[0].upper() != "Y":
sys.exit(0)
cf['_query_on_start'] = 0
- cf['_set_id3tag'] = 0
else:
jack_display.exit()
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
