Hi, On Fri, 2007-12-28 at 20:02:01 -0800, Rudi Cilibrasi wrote: > On Dec 28, 2007 7:37 PM, Guillem Jover <[EMAIL PROTECTED]> wrote: > > Package: libcomplearn-mod-ppmd > > Version: 1.0.6-1 > > Severity: important > > Tags: security > > > > This package contains an embedded copy of the ppmd source. It should > > be using the external program instead for security reasons and to get > > the benefits of the portability patches (also most probably the > > binaries for the 64 bit arches are going to segfault, as the upstream > > code is not 64 bit clean).
> Thanks for the heads-up. As it turns out, this package is not duplicate > source. It is a derived work made by Maarten Keijzer. The "librification" > was done by him for the purpose of this module. Coder.hpp | 0 Model.cpp | 13 +++++-------- PPMd.h | 3 +-- PPMdType.h | 44 +++++++------------------------------------- SubAlloc.hpp | 0 3 files changed, 13 insertions(+), 47 deletions(-) This is a total of 60 KiB of duped source code except for those lines changed as shown in the diffstat. > If it is broken on 64-bit machines then I think I will need to remove > it from the build. But that has yet to be demonstrated on this version. > I am closing this bug until evidence to that effect comes to me. Just check the ppmd package. The patches should apply mostly cleanly, and there's no significant differences that would fix any 64 bit clean issue, there's also unaligned access fixes in the ppmd package not present in this one. The segfaults was one of the reasons I added a build time check for the binary, so that it would fail early and not provide broken packages. regards, guillem -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
