On Jan 8, 2008 2:41 PM, Eddy Petrișor <[EMAIL PROTECTED]> wrote: > First, sorry for the long time it took for me to answer. I was on a > medical leave and I had limited access to internet during the winter > holidays. > > Second, thanks for your work. I really appreciate it. > > On 05/01/2008, Andres Mejia <[EMAIL PROTECTED]> wrote: > > Here's another patch that allows the use of an svn property > > 'svn-bp:useOrigUrl' that works the same as the '--svn-use-origurl' > > option. This patch also adds an '--svn-reconfigure' option to > > reconfigure the deb-layout, useful in case options keep changing. > > .svn/deb-layout is a local override and since 0.6.22 it is no longer > created by svn-buildpackage. I think is futile to create code update a > file that is mere local override. Of course, arguments in favour of > your proposal might make me changemy mind.
I was under the impression that it did create it still. I've been using 0.6.23 of the svn-buildpackage and I don't have the svn-savecfg enabled. I would delete the layout file but then svn-buildpackage would always recreate it. Not having to use the layout file would be nice though. > About the other changes, I think that the idea of fetching the orig > tarball via a script should be designed as a "I want to update to the > newest version" scenario. In other words, I think this should a > manually commanded fetch so that the maintainer explicitly does the > upgrade and, when it does so it should rely on the get-orig-source > rule specified by the debian policy. My idea was to keep the commands to generate an orig tarball out of debian/rules and onto a seperate script, file. I have reasons for wanting to use an external script, like when the script is especially complicated. Take a look at http://svn.debian.org/wsvn/pkg-games/packages/trunk/warsow/debian/warsow-get-orig-source?op=file&rev=0&sc=0 > Also, it might, indeed make sense to try to fetch the tarball from an > upstream location, but the way that is done should rely on the watch > file and/or the get-orig-source rule. I see no point in going around > the policy and create some external scripts for this purpose. uscan has it's own limitations I think. See http://bugs.debian.org/458789 . The get-orig-source rule is optional anyway, according to policy. However, I'm sure it can be possible to use it just as much the same way as with the debOrigScript option. It should be possible to specify "debian/rules" for "debOrigScript" and "get-orig-source" for "debOrigScriptOptions". As long as the get-orig-source rule is written to comply with policy, it should work without a problem. I haven't personally tested this however. > In any case, I will soon look closer at your changes and tell you my > opinion, but I have a feeling you over-complicate the problem. I would > rather make svn-inject smarter or expand on the meaning of the > svn-bp:origUrl property and how is handled rather than adding a new > mechanism. > > > In any case, thanks for the support. Maybe you'll like to tackle one > of the points in the todo[1] file meanwhile (may I suggest the last > one?). > > > [1] > http://svn.debian.org/wsvn/collab-maint/deb-maint/svn-buildpackage/trunk/debian/TODO?op=file&rev=0&sc=0 > -- > Regards, > EddyP > ============================================= > "Imagination is more important than knowledge" A.Einstein > Ok, I'll give it a try when I have time. -- Regards, Andres Mejia
