On Tue, Feb 12, 2008 at 12:25:13AM +0100, Frank Lichtenheld wrote: > On Mon, Feb 11, 2008 at 11:47:13PM +0100, Soren Hansen wrote: > > diff -Nru /tmp/63ah7FRjAl/dpkg-1.14.16.6ubuntu1/scripts/Dpkg/Control.pm > > /tmp/fQCCS9NM6H/dpkg-1.14.16.6ubuntu2/scripts/Dpkg/Control.pm > > --- dpkg-1.14.16.6ubuntu1/scripts/Dpkg/Control.pm 2008-01-18 > > 11:12:53.000000000 +0100 > > +++ dpkg-1.14.16.6ubuntu2/scripts/Dpkg/Control.pm 2008-02-11 > > 23:20:11.000000000 +0100 > > @@ -78,7 +78,7 @@ > > my ($self, $file) = @_; > > $self->reset(); > > # Parse > > - open(CDATA, "<", $file) || syserr(_g("cannot read %s"), $file); > > + open(CDATA, "< $file") || syserr(_g("cannot read %s"), $file); > > Hmm, whatever problem you saw, this most certainly is not the right fix! > Both lines are semantically identical... (barring any serious Perl > bugs).
Granted my perl-fu is not that strong, and looking at the documentation, I might have exaggerated the extent of this bug somewhat. > Could you please go into more detail what you tried to fix? The particular bug I was fixing was when called with "-c-", i.e. read the control file from stdin. From perldoc: In the 2-arguments (and 1-argument) form opening '-' opens STDIN and opening '>-' opens STDOUT. Without my patch, it's the 3-argument version of open, so opening "-" fails (as there is no such file). > Error messages? From pkg-create-dbgsym: dpkg-gencontrol: failure: cannot read -: No such file or directory > Launchpad bug number? Didn't bother doing the paper work :) -- Soren Hansen Virtualisation specialist Ubuntu Server Team http://www.ubuntu.com/
signature.asc
Description: Digital signature