[Bernd Zeimetz, 17.02.2008] > > diff -u musiclibrarian-1.6/debian/control musiclibrarian-1.6/debian/control > > --- musiclibrarian-1.6/debian/control > > +++ musiclibrarian-1.6/debian/control > > @@ -5,22 +5,20 @@ > > -Build-Depends: debhelper (>= 5.0.37.2), python-central (>= 0.5) > > -Build-Depends-Indep: debhelper (>= 5.0.37.2), python-central (>= 0.5), > > python (>= 2.3.0), python-dev (>= 2.3.0) > > -Standards-Version: 3.6.0 > > +Build-Depends: debhelper (>= 5.0.38) > > +Build-Depends-Indep: python-central (>= 0.5.6), python-all-dev (>= > > 2.3.5-11) > > why python-all-dev? Is there a c module to compile? the right fix would > be to drop python-dev. Also you need at least python in build-depends, > as you need it for the clean target (if you'd run setup.py clean in > there, which is the proper way....)
ok, it should be python-all, my fault, but still, byte compiling for all supported Python versions makes sense (I already detected a bug before uploading to unstable once) Since Daniel doesn't maintain Python modules we (Barry and I) decided to byte compile it for all versions, like in Python extensions (we both think that it has more advantages than disadvantages) > > +XS-Python-Version: all > > +Homepage: http://alioth.debian.org/projects/musiclibrarian > > > > Package: musiclibrarian > > Architecture: all > > Depends: ${python:Depends}, python-gtk2 (>= 2.4.0), python-glade2, > > python-pyvorbis, python-id3, python-pyao, python-pymad, libglade2-0 (>= > > 1:2.4.1) > > -XS-Python-Version: current > > XB-Python-Version: ${python:Versions} > > ... should be installed for the current version only, and modules moved > into a private module dir imho (see below). not in NMU, Daniel decided to not install it as a private module so we didn't change it > > diff -u musiclibrarian-1.6/debian/rules musiclibrarian-1.6/debian/rules > > --- musiclibrarian-1.6/debian/rules > > +++ musiclibrarian-1.6/debian/rules > > @@ -6,29 +6,35 @@ > > # Uncomment this to turn on verbose mode. > > #export DH_VERBOSE=1 > > > > +PYVERS=$(shell pyversions -vr) > > + > > Why!? For private modules? see above > > CFLAGS = -Wall -g > > > > clean: > > dh_testdir > > dh_testroot > > - rm -f build-stamp configure-stamp > > + -rm -rf build > > Where's the sense of the - at the begin? man rm. > You should run setup.py clean and search for *.pyc and remove the > files, in case setup.py leaves them sitting around. ok "-" should be removed but calling setup.py clean forces changes in Build-Depends (moving python-all from -Indep) which should not be done in NMU, IMO again, my fault (I suggested to use test -e, though) > > + rm -f build-stamp configure-stamp install-stamp > > > > dh_clean > > > > # Nothing to do to build the package. > > build: > > > > -install: > > +install: install-stamp > > +install-stamp: $(PYVERS:%=install-python-%) > > + touch $@ > > + > > + sed -i -e '1s/python.*/python/' > > $(CURDIR)/debian/musiclibrarian/usr/bin/music-librarian > > Did you think about that? It will be called for all python versions you > build for (which doesn't make sense anyway...). It should not even be > necessary if you build it with the default python version. nope, sed is in install-stamp, not in install-python-% > > + > > +install-python-%: > > dh_testdir > > dh_testroot > > - dh_clean -k > > - dh_installdirs > > > > - ./setup.py install --no-compile > > --prefix=$(CURDIR)/debian/musiclibrarian/usr > > + python$* ./setup.py install --no-compile > > --prefix=$(CURDIR)/debian/musiclibrarian/usr > > Again, runnign setup once with python is enough. Better fix the package > to use a private modules dir like /usr/share/musiclibrarian only. > pycentral will handle that... see above (BTW: I agree that it should be private) > > + rmdir $(CURDIR)/debian/musiclibrarian/usr/lib > > This will FTBFS as soon as pycentral is fixed. I suggested to use rmdir instead of "rm -f" to be sure that this dir is empty. I simply assumed that #452227 will not be fixed. Sorry.
pgpEyQR6oGqnD.pgp
Description: PGP signature
