Package: libsvn-notify-perl
Severity: wishlist

Log messages in HTML emails should be permitted to wrap.  The <pre> tag doesn't 
really permit wrapping.

Patch attached.

-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.6.18-4-686
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
--- HTML.pm.old 2008-02-21 15:42:23.000000000 +1100
+++ HTML.pm     2008-02-22 08:22:32.000000000 +1100
@@ -228,7 +228,7 @@
       qq(#msg dl a:visited { color:#cc6; }\n),
       q(h3 { font-family: verdana,arial,helvetica,sans-serif; ),
           qq(font-size: 10pt; font-weight: bold; }\n),
-      q(#msg pre { overflow: auto; background: #ffc; ),
+      q(#msg pre, div.log { overflow: auto; background: #ffc; ),
           qq(border: 1px #fc0 solid; padding: 6px; }\n),
       qq(#msg ul, pre { overflow: auto; }\n),
       q(#header, #footer { color: #fff; background: #636; ),
@@ -332,7 +332,8 @@
     }
 
     # Print it out and return.
-    print $out "<h3>Log Message</h3>\n<pre>$msg</pre>\n\n";
+    $msg =~ s/\n/\n<br>/g;
+    print $out "<h3>Log Message</h3>\n<div 
class=\"log\"><tt>$msg</tt></div>\n\n";
     return $self;
 }

Reply via email to