Package: tcl8.4 Version: 8.4.16-4 Tags: patch User: [EMAIL PROTECTED] Usertags: origin-ubuntu ubuntu-patch hardy
Hi folks, The tcl8.4 debian/rules has an error in the handling of the CFLAGS variable: spaces should not be quoted in make variable assignments because the quotes become part of the variable content, but do need to be quoted when passing such variables to the shell via make rules. The current debian/rules will cause build failures if CFLAGS is set in the environment, as a result of the quotes being handled wrong. Attached is a patch which corrects this issue. Cheers, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ [EMAIL PROTECTED] [EMAIL PROTECTED]
diff -Nru tcl8.4-8.4.16/debian/changelog tcl8.4-8.4.16/debian/changelog --- tcl8.4-8.4.16/debian/changelog 2008-02-25 06:11:40.000000000 +0000 +++ tcl8.4-8.4.16/debian/changelog 2008-02-25 06:11:40.000000000 +0000 @@ -1,3 +1,12 @@ +tcl8.4 (8.4.16-4ubuntu1) hardy; urgency=low + + * debian/rules: quote CFLAGS when passing to the shell, not when + assigning to a make variable; otherwise the quotes end up as part of + the variable and many things go wrong, leading to a build failure. + LP: #194560. + + -- Steve Langasek <[EMAIL PROTECTED]> Mon, 25 Feb 2008 04:14:58 +0000 + tcl8.4 (8.4.16-4) unstable; urgency=medium * Temporarily (until transition to a new Tcl/Tk policy is done) readded diff -Nru /tmp/p1XM04NFAm/tcl8.4-8.4.16/debian/rules /tmp/wM0ePwrDNC/tcl8.4-8.4.16/debian/rules --- tcl8.4-8.4.16/debian/rules 2008-02-25 06:11:40.000000000 +0000 +++ tcl8.4-8.4.16/debian/rules 2008-02-25 06:11:40.000000000 +0000 @@ -9,10 +9,10 @@ v = 8.4 ifneq (,$(findstring debug,$(DEB_BUILD_OPTIONS))) -CFLAGS="-g -O0" +CFLAGS=-g -O0 else # See bug #446335 -CFLAGS="-g -O2 -fno-unit-at-a-time" +CFLAGS=-g -O2 -fno-unit-at-a-time endif unpatch: @@ -43,7 +43,7 @@ --enable-man-symlinks \ --enable-man-compression=gzip && \ touch ../generic/tclStubInit.c && \ - $(MAKE) CFLAGS=$(CFLAGS) + $(MAKE) CFLAGS="$(CFLAGS)" # Build the static library. cd unix && \
