Sorry for the late answer.

Am Sonntag, den 16.03.2008, 17:07 -0700 schrieb Russ Allbery:
> Daniel Leidert <[EMAIL PROTECTED]> writes:
> 
> > Please consider docbook-defguide and docbook-xml/docbook-simple as
> > examples. In these packages I created a build-system (docbook-defguide)
> > or catalogs (docbook-xml, docbook-simple). Because I use a patch system
> > to change upstream sources, lintian complains about the fact, that I do
> > not create these files by patch.
> >
> > It simply doesn't make sense to create these files by patch.
> 
> Why not?

I could ask the opposite: Why do you think it makes sense to create
files by patch?

> > lintian should only warn, if changes are really changes to an existing
> > file, but not if "change" means, that a file has been created.
> 
> I can see why you did it the way that you did, but I don't see any clear
> advantages over doing it that way versus creating the build files in a
> dpatch.

It makes the life of the package maintainer or any contributor harder.

I also don't create examples in the debian/ directory by patch. I simply
write them and put them under debian/. Why shouldn't I do this for files
outside of debian/ as long as these files are part of the Debian
packaging.

In the above cases we speak about compilation packages, that are not
provided by upstream in this form. In the case of docbook-defguide the
created files are a self-written build-system.

> It seems like about the same thing to me.  Not warning about
> newly created files would miss some of the things that this check is
> designed to look for (basically, editing the package without being aware
> that there's an existing patch system).  If a patch created a file and
> that file was also shipped in the diff, you end up putting the patch
> system in an inconsistent state.

This is true. But it is wrong for changes, that create a file. All you
said is valid for existing files, that are changed. But you cannot put
the patch system in an inconsistent state by creation of files.

I would really suggest to downgrade this warning (W) for existing files
to an information (I). There is no danger and there are clearly
situations, where creation fo these files by patch makes less or at
least only the same sense then creation of these files without a patch
system.

Regards, Daniel




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to