Package: pcscd
Version: 1.4.100-2
Severity: normal
Tags: patch

Hello,

From version 1.4.100-2 pcscd depends on hal [1], but the LSB headers in
the init script doesn't show this dependency.  This should mean that
when using the dependency based boot [2], pcscd isn't started after hal.

I wrote "should" because while this is true on my sid (/etc/rc2.d/ has
S20pcscd and S21hal), I cannot reproduce it on a minimal cowbuilder
chroot (/etc/rc2.d/ has S12hal and S12pcscd).

The patch is trivial and attached: according to [3], I think
Should-Start/Stop are the correct keywords, because AFAIK hal is
necessary for USB readers only, so PCMCIA ones shouldn't require it
(unfortunately I don't have a PCMCIA one here ATM, so I cannot confirm).
Moreover, pcscd doesn't fail to start if hal isn't present, but it only
print a message:

=====
[EMAIL PROTECTED]:/home/luca# invoke-rc.d pcscd stop
Stopping PCSC Lite resource manager: pcscd.
[EMAIL PROTECTED]:/home/luca# invoke-rc.d hal stop
Stopping Hardware abstraction layer: hald.
[EMAIL PROTECTED]:/home/luca# pcscd -f
00000000 pcscdaemon.c:275:main() pcscd set to foreground with debug \
 send to stderr
00000543 pcscdaemon.c:493:main() pcsc-lite 1.4.100 daemon ready.
00120299 hotplug_libhal.c:484:HPRegisterForHotplugEvents() Could not \
 initialise connection to hald.
00000014 hotplug_libhal.c:485:HPRegisterForHotplugEvents() Normally \
 this means the HAL daemon (hald) is not running or not ready.
[...]
[EMAIL PROTECTED]:/home/luca#
=====

Here's the patch against the SVN repository (tested on my sid):

--8<---------------cut here---------------start------------->8---
Index: debian/changelog
===================================================================
--- debian/changelog    (revision 9029)
+++ debian/changelog    (working copy)
@@ -1,3 +1,10 @@
+pcsc-lite (1.4.100-3) UNRELEASED; urgency=low
+
+  * debian/pcscd.init: add hal to LSB Should-Start/Stop.  Closes: #NNN:
+    "pcscd: LSB init script doesn't depend on hal"
+
+ --
+
 pcsc-lite (1.4.100-2) unstable; urgency=low
 
   * debian/control: add Depends: hal. Closes: #472493: "pcscd: must depends on
Index: debian/pcscd.init
===================================================================
--- debian/pcscd.init   (revision 9029)
+++ debian/pcscd.init   (working copy)
@@ -10,8 +10,8 @@
 # Provides: pcscd
 # Required-Start: $local_fs $remote_fs $syslog
 # Required-Stop: $local_fs $remote_fs $syslog
-# Should-Start: usbmgr udev hotplug
-# Should-Stop: usbmgr udev hotplug
+# Should-Start: usbmgr udev hotplug hal
+# Should-Stop: usbmgr udev hotplug hal
 # Default-Start: 2 3 4 5
 # Default-Stop: 0 1 6
 # Short-Description: Daemon to access a smart card using PC/SC
--8<---------------cut here---------------end--------------->8---

Thx, bye,
Gismo / Luca

Footnotes: 
[1] http://bugs.debian.org/472493
[2] http://wiki.debian.org/LSBInitScripts/DependencyBasedBoot
[3] http://wiki.debian.org/LSBInitScripts

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages pcscd depends on:
ii  hal                         0.5.11~rc2-1 Hardware Abstraction Layer
ii  libc6                       2.7-10       GNU C Library: Shared libraries
ii  libccid [pcsc-ifd-handler]  1.3.5-1      PC/SC driver for USB CCID smart ca
ii  libdbus-1-3                 1.1.20-1     simple interprocess messaging syst
ii  libhal1                     0.5.11~rc2-1 Hardware Abstraction Layer - share
ii  lsb-base                    3.2-6        Linux Standard Base 3.2 init scrip

pcscd recommends no packages.

-- no debconf information

Attachment: pgprzLapoqmiA.pgp
Description: PGP signature

Reply via email to