Package: dh-make-perl
Version: 0.42
Severity: normal
Tags: patch

Running

        dh-make-perl --build --cpan Devel::FindRef

results in a package libdevel-findref-perl_1.2-1_all.deb, where I hoped
that since it contains some xs it'd be "_i386.deb".


I suspect in check_for_xs() the precedence of ! is higher than =~,

        ! $File::Find::name =~ /$opts{exclude}/

so no file is ever considered an xs.  Perhaps it could use !~ (below),
or some parens.


Incidentally, nosing around it looks like the "." in ".svn" of the
default $opts{exclude} pattern might want want to be escaped, though I
don't suppose a file "/Zsvn/myfile.xs" ever occurs in practice.


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i586)

Kernel: Linux 2.6.24-1-486
Locale: LANG=en_AU, LC_CTYPE=en_AU (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash

Versions of packages dh-make-perl depends on:
ii  debhelper                     7.0.8      helper programs for debian/rules
ii  dpkg-dev                      1.14.18    package building tools for Debian
ii  fakeroot                      1.9.5      Gives a fake root environment
ii  libmodule-depends-perl        0.10-1.1   identify the dependencies of a dis
ii  libwww-mechanize-perl         1.34-2     Automate interaction with websites
ii  libyaml-perl                  0.62-1.1   YAML Ain't Markup Language (tm)
ii  make                          3.81-4     The GNU version of the "make" util
ii  perl                          5.10.0-9   Larry Wall's Practical Extraction 
ii  perl-modules [libpod-parser-p 5.10.0-9.1 Core Perl modules

Versions of packages dh-make-perl recommends:
ii  apt-file                     2.1.1       APT package searching utility -- c
ii  libmodule-build-perl         0.2808.01-2 Subclassable and make-independent 
ii  perl-modules [libmodule-buil 5.10.0-9.1  Core Perl modules

-- no debconf information

--- dh-make-perl.old	2008-05-09 12:09:37.000000000 +1000
+++ dh-make-perl	2008-05-09 12:15:48.000000000 +1000
@@ -880,7 +880,7 @@
 }
 
 sub check_for_xs {
-	(! $opts{exclude} || ! $File::Find::name =~ /$opts{exclude}/) && /\.(xs|c|cpp|cxx)$/i && do {
+	(! $opts{exclude} || $File::Find::name !~ /$opts{exclude}/) && /\.(xs|c|cpp|cxx)$/i && do {
 		$arch = 'any';
 	};
 }

Reply via email to