On Sun, 18 May 2008, Petter Reinholdtsen wrote:

> 
> tags 448979 + patch
> thanks
> 
> [David Härdeman]
> > Would it perhaps be an idea to move the usplash startup to the
> > usplash init.d script as it's stop action? Then the usplash init.d
> > link could be moved from /etc/rc[06].d/K01usplash to
> > /etc/rc[06].d/K02usplash (since gdm is at prio K01)?
> 
> I believe this is the correct approach to get usplash started on
> systems without gdm and kdm installed.  Here is a patch to make sure
> usplash is started during shutdown when the init.d script is executed.
> With dependency based boot sequencing usplash is started very early in
> the shutdown sequence, and this is sufficient to solve the issue.
> 
> This patch uses the new splash API presented to sysvinit, and rewrites
> how the kernel arguments are parsed to make sure it is handled the
> same way as in sendsigs.

thanks just a quick review.
 
> diff -ur usplash-0.5.19/debian/usplash.init 
> usplash-0.5.19-pere/debian/usplash.init
> --- usplash-0.5.19/debian/usplash.init        2008-05-18 11:02:39.000000000 
> +0200
> +++ usplash-0.5.19-pere/debian/usplash.init   2008-05-18 11:08:40.000000000 
> +0200
> @@ -32,6 +32,8 @@
>  
>  test -x $DAEMON || exit 0
>  
> +. /lib/init/splash-functions
> +
>  set -e
>  
>  usplash_quit() {
> @@ -85,8 +87,20 @@
>       usplash_quit
>       ;;
>    stop)
> -     if grep -q splash /proc/cmdline; then
> -             usplash_write "TIMEOUT 15"
> +     SPLASH=false
> +     if [ -f /proc/cmdline ] ; then
> +         for x in $(cat /proc/cmdline); do
> +             case $x in
> +                 splash*)
> +                     SPLASH=true
> +                     ;;
> +             esac
> +         done
> +     fi
> +
> +     if [ "$SPLASH" = "true" ] ; then
> +         splash_start
> +         splash_stop_indefinite
>       fi
>       ;;
>    *)

aboves is wrong we assume usplash is running unless nosplash is
given (yes the script is currently wrong too, there is another
bug report on that).
 
happy weekend

-- 
maks



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to