Daniel Kahn Gillmor <[EMAIL PROTECTED]> writes: > On Mon 2008-05-19 18:32:21 -0400, Simon Josefsson wrote: > >> Certtool only opens the --outfile file for writing, so there is only >> one file to consider. However, maybe at some point certtool will >> write more than one file. Is the following a good idea? > > Your proposed change seems reasonable to me
Thanks, applied. > (though maybe you want to wrap the stanzas in #ifdef HAVE_UMASKs like > the original). Actually, I have removed all HAVE_UMASK tests. There is no system that I know of that doesn't have umask, and disabling this code can have security consequences so it is better if we get reports regarding systems that doesn't have umask. Even GNU CoreUtils uses umask unconditionally, and it has been widely ported, so I don't expect many problems. /Simon -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
