tag 383090 + patch severity 383090 serious usertag 383090 + intend-to-nmu thanks
Though it is guaranteed that this codepath will cause a segfault on certain architectures, it is not guaranteed that this codepath would ever be executed (e.g., if the returned pointer is never dereferenced). However, this bug does prevent the ia64 buildd from successfully building this package, resulting in a practical FTBFS issue and warranting the serious severity. I'm no longer seeing a build failure when removing -DGNOME_DISABLE_DEPRECATED - perhaps this was fixed with the NMU that resolved #444511. Therefore I propose the following patch. I'll plan to NMU with this patch in a week's time, or sooner if requested by the maintainer. -- dann frazier
diff -urpN lock-keys-applet-1.0.orig/src/Makefile.am lock-keys-applet-1.0/src/Makefile.am --- lock-keys-applet-1.0.orig/src/Makefile.am 2008-05-20 13:12:02.000000000 -0600 +++ lock-keys-applet-1.0/src/Makefile.am 2008-05-20 13:12:16.000000000 -0600 @@ -1,6 +1,5 @@ INCLUDES = -I$(top_srcdir) -I$(includedir) $(LK_APPLET_CFLAGS) \ -DGNOMELOCALEDIR=\""$(datadir)/locale"\" \ - -DGNOME_DISABLE_DEPRECATED \ -DGDK_DISABLE_DEPRECATED \ -DG_DISABLE_DEPRECATED \ -DDATADIR=\""$(datadir)/"\" \ diff -urpN lock-keys-applet-1.0.orig/src/Makefile.in lock-keys-applet-1.0/src/Makefile.in --- lock-keys-applet-1.0.orig/src/Makefile.in 2008-05-20 13:12:02.000000000 -0600 +++ lock-keys-applet-1.0/src/Makefile.in 2008-05-20 13:12:20.000000000 -0600 @@ -173,7 +173,6 @@ sysconfdir = @sysconfdir@ target_alias = @target_alias@ INCLUDES = -I$(top_srcdir) -I$(includedir) $(LK_APPLET_CFLAGS) \ -DGNOMELOCALEDIR=\""$(datadir)/locale"\" \ - -DGNOME_DISABLE_DEPRECATED \ -DGDK_DISABLE_DEPRECATED \ -DG_DISABLE_DEPRECATED \ -DDATADIR=\""$(datadir)/"\" \