tag 484046 patch upstream
thanks
On Sun, Jun 01, 2008 at 09:26:06PM -0600, [EMAIL PROTECTED] wrote:
> Package: libaudio-flac-header-perl
> Version: 2.2-1
> Severity: serious
> There was an error while trying to autobuild your package:
> > t/write.............dubious
> > Test returned status 0 (wstat 11, 0xb)
> > DIED. FAILED tests 3-7
OK, I've got it now.
This is not hppa specific, it just happens to trigger only there. The
problem is that FLAC__metadata_object_vorbiscomment_append_comment()
is called with an uninitialized FLAC__StreamMetadata_VorbisComment_Entry
struct from Header.xs:639.
When the 'length' member happens to be non-zero,
FLAC__format_vorbiscomment_entry_is_legal() tries to dereference an
invalid pointer generating a segmentation fault.
Patch attached, this builds fine for me on hppa and amd64.
The bug was introduced in upstream version 2.2. I'll forward this
to the upstream author probably later today.
--
Niko Tyni [EMAIL PROTECTED]
diff --git a/Header.xs b/Header.xs
index c15c0b5..4e7adcc 100644
--- a/Header.xs
+++ b/Header.xs
@@ -636,6 +636,7 @@ _write_XS(obj)
}
FLAC__StreamMetadata_VorbisComment_Entry entry;
+ entry.length = 0;
FLAC__metadata_object_vorbiscomment_append_comment(block, entry, /*copy=*/true);
if (hv_iterinit(tags)) {
