On Wed, Jun 11, 2008 at 4:00 AM, Bernhard R. Link <[EMAIL PROTECTED]> wrote: > Thanks for testing reprepro there. But please note reprepro is targeted > for systems using glibc or other compatible ones having all the gnu > extensions I like to use, as I deem reprepro seldom useful outside Debian > systems.
No problem. >> - The last parameter for execl() should be (char*)NULL, not just NULL, >> in case char* is a different size to whatever NULL resolves to. GCC >> 4.3 warns about this on AIX. > > What is NULL there? I'm assuming NULL is (void)0 (and not simply 0). > Does compiling with "-DNULL=(void*)0" help? NULL is 0, as per C99 sections 7.17.3 and 6.3.2.3.3; defining NULL to (void*)0 helps. The Open Group examples at http://www.opengroup.org/onlinepubs/000095399/functions/exec.html do all use (char *)0. > I think that can also easily worked around by just adding -DO_NOFOLLOW=0 > to CPPFLAGS. True. This could also go into configure with AC_CHECK_DECL, but that might be a bit dangerous. > Aren't vasnprintf and dprintf in libiberty, too? At least vasnprintf I > would have expected there. It is, though I don't see dprintf. Of course, I only started looking for getopt_long once I'd reimplemented mprintf(); I could have saved myself quite a bit of time. >> - _D_EXACT_NAMELEN is a GNU extension. I just use strlen(r->d_name) if >> it isn't defined. > > Well, this could be fixed with a -D, too. But I think that is garanteed > to be an #define and it's only three lines in an header, so I added > that. And for what it's worth, _D_EXACT_NAMELEN would expand to exactly that in this case. > Does it really produce correct .gz files when you just prevent the > safety guard against too old versions (At least I an hardly imagine > they have an gz header)? Thanks for setting me straight, I should have looked further first. Now I get to see whether I can recompile zlib without breaking the custom version of OpenSSH here. I'll see how I go with libiberty and zlib 1.2. Thanks. -- Laissez lire, et laissez danser; ces deux amusements ne feront jamais de mal au monde. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
