On Sun, 22 Jun 2008, Felipe Sateler wrote: > > Your patch would be even better if it was > > complete: please update the documentation of dpkg-buildpackage accordingly. > > OK. This means editing man/dpkg-buildpackage.1?
Yes. > > I don't know if we want to put both in the same module or if we need to > > come up with a different name (or a sub-module maybe). > > I can try doing this, although I couldn't find an appropriate name (perhaps > Source::BuildOptions?). The idea would be to add one function per build > option, or one function that processes them all? I think it's best to do one > function per build option, since an option can touch any part of the process. I'm not yet 100% sure what the best design is. I think both DEB_BUILD_OPTIONS and Build-Options are going to be closely tied anyway... Build-Options is a way to express that the package supports a set of functionalities and often those will be enabled through a keyword in DEB_BUILD_OPTIONS. As such, it probably makes sense to add support for both in the same module but with different commands to allow checking one set or the other or both. Ideally the module a has a list of keywords with meta-information that says where the keyword is allowed/expected, if it accepts a value (keyword=value, like parallel=4), if it represents a "supported feature" (always to be found in Build-Options:) or a "request to enable" something specific (usually in DEB_BUILD_OPTIONS, but could also be in Build-Options maybe). Here you would also put the minimal Standards-Version where the feature can be considered as always supported (unless there's an opposite keyword "no-<keyword>" in the list). This will require refactoring of the module and thus also of its associated test suite (scripts/t/300_Dpkg_BuildOptions.t) (and of dpkg-buildpackage that uses it already). Cheers, -- Raphaël Hertzog Le best-seller français mis à jour pour Debian Etch : http://www.ouaza.com/livre/admin-debian/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
