Tags: patch

Michael Alan Dorman wrote:

> Package: unbound
> Version: 1.0.0-3
> Severity: important
> 
> If you run dash as your /bin/sh, the init script fails.  Changing the
> shebang line to /bin/bash resolves the issue.  The issue seems to be
> with the already_running() function, perhaps specifically the 'return'
> statement.

This is actually not a problem of whether it is bash or dash, return takes
an unsigned integer as an argument.

> already_running() {
>     return start-stop-daemon --start --pidfile $PIDFILE \
>         --startas $DAEMON --test >/dev/null 2>&1
> }

should be as simple as:

> already_running() {
>     start-stop-daemon --start --pidfile $PIDFILE \
>         --startas $DAEMON --test >/dev/null 2>&1
> }

Because the function returns the exit status of the last command executed
(start-stop-daemon in this case).

> 
> Either way, with the number of people who install dash to get better
> performance, I think this warrants being marked as important.
> 
> -- System Information:
> Debian Release: lenny/sid
>   APT prefers testing
>   APT policy: (500, 'testing')
> Architecture: i386 (i686)
> 
> Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
> Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
> Shell: /bin/sh linked to /bin/dash
> 
> Versions of packages unbound depends on:
> ii  adduser                      3.108       add and remove users and
> groups
> ii  libc6                        2.7-10      GNU C Library: Shared
> libraries
> ii  libldns1                     1.3.0-1     ldns library for DNS
> programming
> ii  libssl0.9.8                  0.9.8g-10.1 SSL shared libraries
> 
> unbound recommends no packages.
> 
> -- no debconf information

Cheers,
-- 
Atomo64 - Raphael

Please avoid sending me Word, PowerPoint or Excel attachments.
See http://www.gnu.org/philosophy/no-word-attachments.html




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to