Hi, On Fri, 2008-07-18 at 17:39:17 +0200, Evgeni Golov wrote: > On Fri, 11 Jul 2008 21:55:38 +0300 Guillem Jover wrote: > > > We still can do this on our own though :) > > > > Good. :)
> Did you test your patch on amd64? v86_lrmi.c seems to be not 64bit > safe. When I compile it on my amd64 with your patch, I get the > following: > v86_lrmi.c: In function ‘v_rdb’: > v86_lrmi.c:7: warning: cast to pointer from integer of different size > v86_lrmi.c: In function ‘v_rdw’: > v86_lrmi.c:11: warning: cast to pointer from integer of different size > v86_lrmi.c: In function ‘v_rdl’: > v86_lrmi.c:15: warning: cast to pointer from integer of different size > v86_lrmi.c: In function ‘v_wrb’: > v86_lrmi.c:19: warning: cast to pointer from integer of different size > v86_lrmi.c: In function ‘v_wrw’: > v86_lrmi.c:23: warning: cast to pointer from integer of different size > v86_lrmi.c: In function ‘v_wrl’: > v86_lrmi.c:27: warning: cast to pointer from integer of different size > v86_lrmi.c: In function ‘vptr’: > v86_lrmi.c:31: warning: cast to pointer from integer of different size > v86_lrmi.c: In function ‘v86_mem_free’: > v86_lrmi.c:104: warning: cast to pointer from integer of different size > v86_lrmi.c: In function ‘v86_mem_alloc’: > v86_lrmi.c:108: warning: cast from pointer to integer of different size > v86d still works, but everyone says me that this is very unsafe... > In fact upstream does not inted to use v86_lrmi.c on !x86, as there > v86_x86emu.c should be used. > Do you have an oppinion on this? I would like not to break anyones > computers :) Sorry saw this mail checked the source but somehow forgot to reply. I've seen you've uploaded this already, but I've not checked if you changed anything at the end. Anyway, the rd/wr functions are not used in the lrmi case. And the warning should be safe, as the 32 bit code is not going to return 64 bit pointers anyway. regards, guillem -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
