Hi Paul,

Am Montag, den 25.08.2008, 10:00 +0800 schrieb Paul Wise:
> Source: screen-message
> Version: 0.14-1
> Severity: wishlist
> 
> The attached patch adds better handling for hiding the edit widget on
> timeouts:
> 
>       * a command-line option to give a custom timeout
>       * doesn't render text underneath the edit widget
>       * timeout doesn't occur when the user is moving the arrow keys
>         around

Thanks for the patch. Two comments though:

 * I’d still like to avoid command line options, and I think the entry
timeout is something that does not have to be configurable. Rather, I
think we can find a more suitable value. Do you think 5 seconds is too
much? What do you use?

 * Rendering the text underneath the edit widget is actually a feature:
Then the text won’t jump when the edit widget is hidden, which I find
nicer. Have you considered that?

 * Thanks for the rest of the patch!

BTW, if you want you can use darcs to record and send your patches. This
would make it easier for you to send separate patches for separate
features, but still all in one .dpatch file. Just use "darcs get
http://darcs.nomeata.de/screenmessage"; to get the sources, "darcs
record" to select and name your patch and "darcs send" to send all your
recorded modifications to me. 

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  [EMAIL PROTECTED] | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: [EMAIL PROTECTED] | http://people.debian.org/~nomeata

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

Reply via email to