Hello Mohammed,

On Sat, Sep 20, 2008 at 19:23, Mohammed Adnène Trojette
<[EMAIL PROTECTED]> wrote:
>
> On Sat, Sep 20, 2008, Dmitry Semyonov wrote:
>> It also fixes dependency list (libapache-mod-php4 |
>> libapache2-mod-php4 instead of php4),
>
> I don't think I will include this, as libapache2-mod-php4 provides php
> and libapache-mod-php4 is not in lenny.

Sorry, you're right. php4 packages remained in my system after upgrade
from Etch, and I didn't realize they're gone in Lenny.
But php4 is also not in Lenny. This causes dependency on various
apache2 modules, (since php5 depends on libapache2-mod-php5 and not
libapache-mod-php5), although I have only apache installed.

So, I think the right solution is to use libapache-mod-php5 |
libapache2-mod-php5 instead of php5 | php4. Also, php4-cli and php4-gd
should be removed from Recommends.

On the other hand libapache-mod-php5 has broken dependency:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=486888
So, dokuwiki + apache bundle will be still broken in Lenny until the
bug is fixed.


>> and Version display by doku.php?do=check URL.
>
> Which bug is it fixing?

There is no separate bug in Debian BTS. While I was using dokuwiki
from Etch backports I noticed that "snapshot?" version is displayed by
http://localhost/dokuwiki/doku.php?do=check URL. I thought it was some
problem with backporting, but found the same issue in Lenny. So,
decided to fix it as well.


>> +    echo "Alias $docroot             /usr/share/dokuwiki" > $apacheconf
>
> Why not >> ?

It was > in perl. Also I forgot that mktemp creates the empty file...

Actually, appending or rewriting makes no difference in this case. So
I'm fine with any of them.


>> +# Subroutine to set up an initial access control system
>> +setup_acl()
>>  {
>> +    # By default allow everyone read access
>> +    if [ ! -a /var/lib/dokuwiki/acl/acl.auth.php ]; then
>
> Do you mean "if [ ! -e /var/lib/dokuwiki/acl/acl.auth.php ..."?

Right, -e is better. 'help test' in bash displays both -a and -e to do
the same check. But -e looks more portable.

Thanks for your comments.

-- 
...Bye..Dmitry.



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to