Am Freitag 03 Oktober 2008 16:33:09 schrieb Gerrit Pape:
> Hi, can you please add instructions on how to reproduce the issue by
> pasting the commands you run?
I've tried to debug it further, and it looks like a combination of
1) PEBKAC,
2) non-cautious Perl programming and
3) not very useful SVN error messages.
1) The authorisation error was due to the line
auth-access = read
instead of the default
auth-access = write
in svnserve.conf. So not being able to commit was correct in that case.
2) Nevertheless something like the attached patch should be committed to
git-svn to let it handle errors without descriptions.
3) SVN should be improved to tell why authorisation failed.
During my tests I've also tried git-svn from experimental. Just a note that
the binary is located in /usr/lib/git-core. This is surely not intended?
Josef
--- Core.pm.backup 2008-07-14 12:41:48.000000000 +0200
+++ Core.pm 2008-07-14 12:44:26.000000000 +0200
@@ -581,8 +581,12 @@
my $error_message = $svn_error->strerror();
while ($svn_error) {
- $error_message .= ': ' . $svn_error->message();
- $svn_error = $svn_error->child();
+ if($svn_error->message()) {
+ $error_message .= ': ' . $svn_error->message();
+ } else {
+ $error_message .= ': {???}';
+ }
+ $svn_error = $svn_error->child();
}
return $error_message;
}
