Am Freitag, den 10.10.2008, 10:27 +0100 schrieb Chris Lamb:
> Norbert Tretkowski wrote:
> > Something went wrong with this upload:
> [..]
> > tags 499508 +pending
> 
> So, version.h wasn't up-to-date in the new tarball?

It was, but the Debian diff reverted the change. This is from your last
upload, 2.0.870~rc3-0.1:

--- open-iscsi-2.0.870~rc3.orig/usr/version.h
+++ open-iscsi-2.0.870~rc3/usr/version.h
@@ -6,7 +6,7 @@
  * This may not be the same value as the kernel versions because
  * some other maintainer could merge a patch without going through us
  */
-#define ISCSI_VERSION_STR      "2.0-870"
+#define ISCSI_VERSION_STR      "2.0-869"
 #define ISCSI_VERSION_FILE     "/sys/module/scsi_transport_iscsi/version"
 
 #endif


But that wasn't the reason why iscsi boot didn't work, the Debian diff
also removed an important part from iscsistart.c:

--- open-iscsi-2.0.870~rc3.orig/usr/iscsistart.c
+++ open-iscsi-2.0.870~rc3/usr/iscsistart.c
@@ -126,19 +126,10 @@
        iscsiadm_rsp_t rsp;
        int rc;
 
-       /*
-        * For root boot we cannot change this so increase to account
-        * for boot using static setup.
-        */
-       config_rec.session.initial_login_retry_max = 30;
        /* we cannot answer so turn off */
        config_rec.conn[0].timeo.noop_out_interval = 0;
        config_rec.conn[0].timeo.noop_out_timeout = 0;
 
-       printf("%s: Logging into %s %s:%d,%d\n", program_name, config_rec.name,
-               config_rec.conn[0].address, config_rec.conn[0].port,
-               config_rec.tpgt);
-
        memset(&req, 0, sizeof(req));
        req.command = MGMT_IPC_SESSION_LOGIN;
        memcpy(&req.u.session.rec, &config_rec, sizeof(node_rec_t));


I really don't know why, it's also not documented in the changelog.
Philipp, do you know something about that change?

Maybe dropping that patch from 2.0.869.2-2.1 would have fixed booting
from iscsi as well, but now we already have 2.0.870-rc3 in unstable... 

        Norbert




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to