Rogério Brito <[EMAIL PROTECTED]> wrote:

Hi,

>> Nope, 10 is the max, trust me :)
>
> Ooops. I didn't read the code. :-) That should be fixed, though.

9 is the last useful level for users. 10 is advanced debug stuff.

>> > Obviously, that function needs to return a int64_t (more correctly, it
>> > would return a size_t, if I understood it correctly).
>> 
>> Yes that should be a size_t, except that there's an abstraction layer,
>> so it's a uint64_t.
>
> Sorry. I'm a bit lost here. Did you intend to say int64_t? I think that
> the abstraction layer may be changed a little bit, so that we do the

No, I meant uint64_t to match the size_t through the abstraction
layer. I was essentially telling that the code was correct in using an
unsigned type for the offset, not taking into account the fact that
the return value of the function should only indicate success/failure.

> right thing (returning -1 when the function says that it will return an
> unsigned int is not a good signal).

You'll not there was a FIXME in the file about that :) But still, that
code was horribly broken.

> I have no golden ears. :-) And I feel a bit uneasy with the lack of faac
> development, especially in the psycho-acoustic part.

They've been shut down due to patent threats, if memory serves me well.

>> Needs libmp4v2, which we cannot have in Debian due to patent issues
>> around MPEG4.
>
> Perhaps we can grab some files from libmp4v2 for the sake of compiling
> easytag with aac support... (Just a wild thought, knowing nothing about
> the complexity of this task).

Read-only support might be OK, write support probably not. I don't
know if anyone tried to get it in Debian, a quick search did not turn
anything up. Might be worth investing a bit of time into that.

> 1 - The AAC files here were generated by iTunes;
> 2 - They show up in the playlist;
> 3 - The don't play.
>
> Hope this helps to clear the situation.

OK, so the fix for the scanner won't help you here. (though you can
test the fix with iTunes files which would be a good thing)

I'd need a log snippet when you're trying to read an AAC file. The log
you sent only contains the startup :)

JB.

-- 
 Julien BLACHE <[EMAIL PROTECTED]>  |  Debian, because code matters more 
 Debian & GNU/Linux Developer        |       <http://www.debian.org>
 Public key available on <http://www.jblache.org> - KeyID: F5D6 5169 
 GPG Fingerprint : 935A 79F1 C8B3 3521 FD62 7CC7 CD61 4FD7 F5D6 5169 



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to