Hi, On Fri, 2008-08-22 at 14:22 +0200, Jörg Sommer wrote: > I would like to see the appended patches be applied to getbuildlog.
Thanks for the patches. > > > > text/x-diff > attachment > (0001-Improve-variable-assignment.patch) > > > > text/x-diff > attachment > (0002-Replace-string-operations-by-shell-expressions.patch) I've applied both of these. > > > > > > text/x-diff > attachment > (0003-Print-a-warning-if-downloading-a-log-a-second-time.patch) [...] > Some packages were built by more than one buildd. Tell the user about > it. > > Example: > http://buildd.debian-ports.org/fetch.php?&pkg=slrn&ver=0.9.8.1pl1-28&arch=armel > http://experimental.debian.net/fetch.php?&pkg=slrn&ver=0.9.8.1pl1-28&arch=armel [...] > + if [ -e "${PACKAGE}_${ver}_${arch}.log" ]; then I haven't applied this patch, as there are good reasons for the log already existing which don't imply that it was built multiple times. For example, if I getbuildlog devscripts 2.10.39 getbuildlog devscripts "" mipsel then the second invocation will redownload the 2.10.39/mipsel log. > > > > text/x-diff > attachment > (0004-Replace-7E-by-in-URLs.patch) Yeah, I should have spotted that one myself when I added the original unescaping; thanks. > > > > > > text/x-diff > attachment > (0005-Fetch-only-last-version-if-version-parameter-is-last.patch) [...] > It's much more handy, especially in scripts, to fetch only the last > version without having to know the version number. I haven't applied this patch, as whilst I agree that it seems like a good idea, this: > - for match in `grep -E -o "$PATTERN" $ALL_LOGS`; do > + last_ver= > + for match in `grep -E -o "$PATTERN" $ALL_LOGS | tac`; do won't work. One can't rely on buildd.d.o returning packages in version order - see http://buildd.debian.org/build.php?arch=&pkg=devscripts for an example. Unfortunately a "| sort" won't work either, as it would need a "sort Debian package numbers" option that understood epochs, tilde versions and so on. I'll most likely add a small perl invocation using Devscripts::Versort. Regards, Adam -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
