Package: svn-load
Version: 0.10-1
Severity: normal
Tags: patch

Hi Dann,

If I give svn-load a non-existent name as the directory to load from, it
will happily delete all the files that previously existed in the svn
import directory.  The attached patch makes svn-load check that any
directories given to load from actually exist and are directories.

Thanks,
-- 
+---------------------------------------------+
| John Wright <john.wri...@hp.com>            |
| HP Alliances, Linux & Performance Solutions |
+---------------------------------------------+
Index: svn-load
===================================================================
--- svn-load	(revision 80)
+++ svn-load	(working copy)
@@ -609,8 +609,13 @@
 
     dirs = expand_dirs(args[2:])
 
-    # Check to make sure the user isn't trying to import an svn working dir
+    # Check to make sure the user isn't trying to import a non-existent dir or
+    # an svn working dir
     for d in dirs:
+        if not os.path.isdir(d):
+            sys.stderr.write("Error: %s does not exist or is not a directory\n"
+                             % d)
+            sys.exit(1)
         if contains_svn_metadata(d):
             sys.stderr.write("Error: %s contains .svn dirs or files\n" % (d))
             sys.exit(1)

Reply via email to