On Tue, Dec 16, 2008 at 10:45:21AM -0800, Jack Bates wrote: > Package: svn-load > Version: 1.1 > Severity: wishlist > Tags: patch > > I wish svn-load supported the Subversion --username, --password, and > --no-auth-cache options:
hey Jack! Thanks for the patch, I'd like to include this support as well. However, I _think_ that we need to do it in a more global way. Your patch sets up the client instance that is used in __main__, but there are several other client instances used throughout the code. This means that these options would only be set for the commit, not for e.g., the source checkout/tagging. One option is to rework NotifiedClient() - make it a class and have it store the configuration for future instances. Another option is to use a single client instance everywhere. I don't really like the aesthetic of passing the client parameter around everywhere but, then again, we're creating a new instance in nearly every function call and that's pretty ugly as well. I suppose we could just make it a global variable. What do you think? -- dann frazier -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
