Hi Yaroslav,

Thanks for reporting. The laptop-mode-tools package is designed to be
resilient w.r.t. old configuration files (in fact, configuration files
from the very first version should still work), so the only reason why
you would want this is if you really really want to get upgrades to the
main config, which is supposed to change only in comments. So I'm
inclined to treat this as a low-priority item for now. I don't mind
adding it at some point though, it'll probably show up in one of the
next releases!

Cheers,
Bart

Yaroslav Halchenko wrote:
> Package: laptop-mode-tools
> Version: 1.47-1
> Severity: wishlist
> Tags: patch
> 
> 
> As it is now, any customization of the parameters described in
> /etc/laptop-mode/laptop-mode.conf
> is either lost if a maintainers version is installed or the whole file
> with customized parameters need to be preserved between upgrades with
> manual patching of a new .conf.dpkg-dist file later on.
> 
> As laptop_mode does it -- it loads conf.d/* files first and then
> laptop-mode.conf later on, so there is no way to override defaults in
> .conf so they are preserved through the upgrades.
> 
> I would suggest a simple, yet imho effective way:
> 
> add  a line
> 
>  [ -r /etc/laptop-mode/laptop-mode.local ] && .  
> /etc/laptop-mode/laptop-mode.local
> 
> either at the end of /etc/laptop-mode/laptop-mode.conf or in laptop_mode
> after sourcing /etc/laptop-mode/laptop-mode.conf file.
> 
> That would allow to define custom changes in
> /etc/laptop-mode/laptop-mode.local
> without impact on any distributed .conf file (so they would be safely
> preserved through upgrades).
> 
> even better approach would be for any .conf (ie under conf.d as well) to
> check if there is a corresponding .local file and source it after
> corresponding .conf (needs to be done in laptop_mode)
> 
> This way it would be easy to add customizations  to any file.
> P.S. Sorry for such a 'verbal' patch -- but I am not sure which way you
> would like to follow (if any)
> 
> -- System Information:
> Debian Release: 5.0
>   APT prefers testing
>   APT policy: (990, 'testing'), (600, 'unstable'), (300, 'experimental')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 2.6.26-1-amd64 (SMP w/2 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/bash
> 
> Versions of packages laptop-mode-tools depends on:
> ii  lsb-base                      3.2-20     Linux Standard Base 3.2 init 
> scrip
> ii  psmisc                        22.6-1     Utilities that use the proc 
> filesy
> ii  util-linux                    2.13.1.1-1 Miscellaneous system utilities
> 
> Versions of packages laptop-mode-tools recommends:
> ii  acpid                       1.0.6-13     Utilities for using ACPI power 
> man
> ii  apmd                        3.2.2-10     Utilities for Advanced Power 
> Manag
> ii  ethtool                     6+20080227-1 display or change ethernet card 
> se
> ii  hal                         0.5.11-3     Hardware Abstraction Layer
> ii  hdparm                      8.9-1        tune hard disk parameters for 
> high
> ii  sdparm                      1.02-1       Output and modify SCSI device 
> para
> 
> laptop-mode-tools suggests no packages.
> 
> -- no debconf information
> 
> 




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to