Modestas Vainius wrote:
> + "exclude-logged" => \$dh{EXCLUDE_LOGGED},
> + "remaining-packages" => \$dh{EXCLUDE_LOGGED},
I don't see a reason to have two names for the same option.
--exclude-logged somewhat exposes internals so I prefer the other one.
> +sub is_helper_in_log {
> + my $cmd=shift;
> + my @packag...@_;
> +
> + foreach my $package (@packages) {
> + my $ext=pkgext($package);
> + if ($ext && open(LOG, "debian/${ext}debhelper.log")) {
> + if (grep /^\Q$cmd\E$/, <LOG>) {
> + close LOG;
> + return $package;
> + }
> + close LOG;
> + }
> + }
> + return undef;
> +}
This is fairly much a duplicate of loadlog from dh, and I think that
both dh and is_in_log could use the same function with some reworking.
> +=item B<--exclude-logged>, B<--remaining-packages>
> +
> +Do not act on the packages which have already been acted on by this helper
> +earlier (i.e. the helper is present in the package debhelper log). Useful
> +for invoking the helper on the packages remaining unprocessed after calling
> +the helper with special options on a few specific packages.
The docs call them denhelper commands, not helpers.
--
see shy jo
signature.asc
Description: Digital signature
