Hi Luca-- On 04/04/2009 05:59 AM, Luca Falavigna wrote: > upstream developer has no time to provide updates to webdeveloper, so I > think I could insert this directly in Debian packaging. Mind adjusting > your patch for 1.1.6?
I hadn't even looked at the source for webdeveloper in a couple years!
I like the packaging changes you've made.
Attached is insert_clean_submit_button.diff, against 1.1.6+repack. You
should be able to just drop it into debian/patches, add the name to
debian/patches/series, adjust debian/changelog to suit, and all should
be good. It works for me.
Thanks for taking over this package and doing this work on it.
Regards,
--dkg
Allow the user to add simple, clean "submit" buttons in every form on the page http://bugs.debian.org/416540 --- webdeveloper-1.1.6+repack.orig/source/locale_common/en-US/webdeveloper/menu.dtd +++ webdeveloper-1.1.6+repack/source/locale_common/en-US/webdeveloper/menu.dtd @@ -154,6 +154,8 @@ <!ENTITY webdeveloper.populate.form.fields.key "P"> <!ENTITY webdeveloper.remove.maximum.lengths.label "Remove Maximum Lengths"> <!ENTITY webdeveloper.remove.maximum.lengths.key "L"> +<!ENTITY webdeveloper.insert.clean.submit.label "Insert Clean Submit Buttons"> +<!ENTITY webdeveloper.insert.clean.submit.key "B"> <!-- Convert Form Methods Features --> <!ENTITY webdeveloper.gets.posts.label "GETs To POSTs"> only in patch2: unchanged: --- webdeveloper-1.1.6+repack.orig/source/locale_common/en-US/webdeveloper/webdeveloper.properties +++ webdeveloper-1.1.6+repack/source/locale_common/en-US/webdeveloper/webdeveloper.properties @@ -144,6 +144,11 @@ webdeveloper_convertSelectElementsToTextInputsSingleResult=1 select element has been converted to a text input. webdeveloper_convertSelectElementsToTextInputsMultipleResult=%S select elements have been converted to text inputs. +# Insert Clean Submit Buttons +webdeveloper_insertCleanSubmit=Insert Clean Submit Buttons +webdeveloper_insertCleanSubmitSingleResult=A clean submit input element has been added to 1 form. +webdeveloper_insertCleanSubmitMultipleResult=Clean submit elements have been added to %S forms. + # Delete Domain Cookies webdeveloper_deleteDomainCookies=Delete Domain Cookies webdeveloper_deleteDomainCookiesSingleConfirmation=Are you sure you want to delete the 1 domain cookie? only in patch2: unchanged: --- webdeveloper-1.1.6+repack.orig/source/content_common/webdeveloper/forms.js +++ webdeveloper-1.1.6+repack/source/content_common/webdeveloper/forms.js @@ -112,6 +112,60 @@ } } +// Inserts simple clean "submit" button in all forms +function webdeveloper_insertCleanSubmit() +{ + var submitsInserted = 0; + var displayFormDetailsMenu = document.getElementById("webdeveloper-display-form-details-menu"); + var documentList = webdeveloper_getDocuments(webdeveloper_getContentWindow()); + var documentLength = documentList.length; + var form = null; + var formLength = null; + var formList = null; + var pageDocument = null; + + // Loop through the documents + for(var i = 0; i < documentLength; i++) + { + pageDocument = documentList[i]; + formList = pageDocument.getElementsByTagName("form"); + formLength = formList.length; + + // Loop through all the forms + for(var j = 0; j < formLength; j++) + { + form = formList[j]; + var sub = pageDocument.createElement("input"); + sub.setAttribute('type', 'submit'); + form.appendChild(sub); + submitsInserted++; + } + } + // Reapply the display form details style sheet if it is currently on - fixes bug with form method not updating + if(displayFormDetailsMenu.getAttribute("checked")) + { + webdeveloper_removeStyleSheet("webdeveloper-display-form-details", false); + webdeveloper_displayFormDetails(displayFormDetailsMenu, false); + } + + // If the hide informational dialogs preference is not set + if(!webdeveloper_getBooleanPreference("webdeveloper.informational.dialogs.hide", true)) + { + var stringBundle = document.getElementById("webdeveloper-string-bundle"); + var title = stringBundle.getString("webdeveloper_insertCleanSubmit"); + + // If one element was enabled + if(submitsInserted == 1) + { + webdeveloper_informationalDialog(title, stringBundle.getString("webdeveloper_insertCleanSubmitSingleResult")); + } + else + { + webdeveloper_informationalDialog(title, stringBundle.getFormattedString("webdeveloper_insertCleanSubmitMultipleResult", [submitsInserted])); + } + } +} + // Converts select elements to text inputs function webdeveloper_convertSelectElementsToTextInputs() { only in patch2: unchanged: --- webdeveloper-1.1.6+repack.orig/source/content_common/webdeveloper/webdeveloper.xul +++ webdeveloper-1.1.6+repack/source/content_common/webdeveloper/webdeveloper.xul @@ -162,7 +162,8 @@ </menupopup> </menu> <menuitem id="webdeveloper-convert-select-elements-text-inputs-menu" accesskey="&webdeveloper.convert.select.elements.text.inputs.key;" label="&webdeveloper.convert.select.elements.text.inputs.label;" oncommand="webdeveloper_convertSelectElementsToTextInputs()"/> + <menuitem label="&webdeveloper.insert.clean.submit.label;" accesskey="&webdeveloper.insert.clean.submit.key;" oncommand="webdeveloper_insertCleanSubmit()"/> <menuseparator id="webdeveloper-forms-separator2-menu"/> <menuitem id="webdeveloper-enable-auto-completion-menu" accesskey="&webdeveloper.enable.auto.completion.key;" label="&webdeveloper.enable.auto.completion.label;" oncommand="webdeveloper_enableFormAutoCompletion()"/> <menuitem id="webdeveloper-enable-form-fields-menu" accesskey="&webdeveloper.enable.form.fields.key;" label="&webdeveloper.enable.form.fields.label;" oncommand="webdeveloper_enableFormFields()"/> <menuseparator id="webdeveloper-forms-separator3-menu"/> @@ -466,6 +467,7 @@ </menupopup> </menu> <menuitem id="webdeveloper-convert-select-elements-text-inputs-context" accesskey="&webdeveloper.convert.select.elements.text.inputs.key;" label="&webdeveloper.convert.select.elements.text.inputs.label;" oncommand="webdeveloper_convertSelectElementsToTextInputs()"/> + <menuitem label="&webdeveloper.insert.clean.submit.label;" accesskey="&webdeveloper.insert.clean.submit.key;" oncommand="webdeveloper_insertCleanSubmit()"/> <menuseparator id="webdeveloper-forms-separator2-context"/> <menuitem id="webdeveloper-enable-auto-completion-context" accesskey="&webdeveloper.enable.auto.completion.key;" label="&webdeveloper.enable.auto.completion.label;" oncommand="webdeveloper_enableFormAutoCompletion()"/> <menuitem id="webdeveloper-enable-form-fields-context" accesskey="&webdeveloper.enable.form.fields.key;" label="&webdeveloper.enable.form.fields.label;" oncommand="webdeveloper_enableFormFields()"/> @@ -768,6 +770,7 @@ </menupopup> </menu> <menuitem id="webdeveloper-convert-select-elements-text-inputs-toolbar" accesskey="&webdeveloper.convert.select.elements.text.inputs.key;" label="&webdeveloper.convert.select.elements.text.inputs.label;" oncommand="webdeveloper_convertSelectElementsToTextInputs()"/> + <menuitem label="&webdeveloper.insert.clean.submit.label;" accesskey="&webdeveloper.insert.clean.submit.key;" oncommand="webdeveloper_insertCleanSubmit()"/> <menuseparator id="webdeveloper-forms-separator2-toolbar"/> <menuitem id="webdeveloper-enable-auto-completion-toolbar" accesskey="&webdeveloper.enable.auto.completion.key;" label="&webdeveloper.enable.auto.completion.label;" oncommand="webdeveloper_enableFormAutoCompletion()"/> <menuitem id="webdeveloper-enable-form-fields-toolbar" accesskey="&webdeveloper.enable.form.fields.key;" label="&webdeveloper.enable.form.fields.label;" oncommand="webdeveloper_enableFormFields()"/>
signature.asc
Description: OpenPGP digital signature
