Package: laptop-mode-tools
Version: 1.47-1
Severity: important
Tags: patch

Hello, this is what udevinfo is returning for me:

$ udevinfo -V
the program '/bin/bash' called 'udevinfo', it should use 'udevadm info 
<options>', this will stop working in a future release
140

The warning goes to stderr, hence

$ VERSION=`udevinfo -V`
the program '/bin/bash' called 'udevinfo', it should use 'udevadm info 
<options>', this will stop working in a future release
$ echo $VERSION
140

Any awk magic that is applied to parse out the version number, as it is done in 
the current versio it is, is consequently rather desastrous, the VERSION 
variable is then empty. Here my suggestion:


--- /usr/share/laptop-mode-tools/modules/hdparm.orig    2009-04-11 
11:57:34.632353805 +0200
+++ /usr/share/laptop-mode-tools/modules/hdparm 2009-04-11 12:04:54.584002679 
+0200
@@ -132,7 +132,11 @@
 HAVE_UDEVINFO=0
 if [ -x "$(which udevinfo 2> /dev/null)" ] ; then
        UDEVVERSION=$(udevinfo -V | awk '{ print $3; }')
-       if [ "$UDEVVERSION" -gt 70 ] ; then
+       if [ -z "$UDEVVERSION" ]; then
+               # newer versions print the version only
+               UDEVVERSION=$(udevinfo -V)
+       fi
+       if [ -n "$UDEVVERSION" -a "$UDEVVERSION" -gt 70 ] ; then
                HAVE_UDEVINFO=1
        else
                $LM_VERBOSE && echo "udevinfo present but version not > 070, 
not using udev" >> $OUTPUT


Thanks and regards

Steffen



-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.28-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages laptop-mode-tools depends on:
ii  lsb-base                      3.2-22     Linux Standard Base 3.2 init scrip
ii  psmisc                        22.6-1     Utilities that use the proc filesy
ii  util-linux                    2.13.1.1-1 Miscellaneous system utilities

Versions of packages laptop-mode-tools recommends:
ii  acpid        1.0.8-7                     Utilities for using ACPI power man
ii  ethtool      6+20090307-1                display or change Ethernet device 
ii  hal          0.5.12~git20090406.46dc48-1 Hardware Abstraction Layer
ii  hdparm       9.12-2                      tune hard disk parameters for high
ii  sdparm       1.02-1                      Output and modify SCSI device para

laptop-mode-tools suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to