On Thu, Apr 30, 2009 at 06:40:12AM +0200, Michael Biebl wrote: > Am 30.04.2009 06:28, schrieb Steve Langasek: >> Package: pm-utils >> Version: 1.2.5-2 >> Tags: patch >> User: ubuntu-de...@lists.ubuntu.com >> Usertags: origin-ubuntu ubuntu-patch karmic
>> pm-utils currently includes a script to call hwclock on suspend and resume, >> to save and restore the system clock. However, recent kernels handle this >> directly, and much more efficiently - having to call hwclock results in a >> full one-second delay on suspend and resume, because of the way this >> userspace tool works. So I strongly recommend not installing this script as >> part of the package. > Well, the script is installed by default, but NEED_CLOCK_SYNC is off in > the default installation, so it is not run. > We kept the script for users of older kernels and left the option to > manually enable it. > Would that satisfy your needs or is your point that the scripts should > be removed altogether, so it can't be enabled mistakenly? Hmm - this surprises me, because as of 1.2.2.4 when this issue was looked at in the jaunty cycle (early February), multiple people were able to confirm that removing this script had a noticeable impact on suspend/resume speed. But I do certainly see the "$NEED_CLOCK_SYNC" check there, and see that it was also present in 1.2.2.4, so I'm at a loss to explain why removing this script made a difference. I think it would probably be better to remove the script altogether (it should not be needed on systems going forward, and there is some cost to having to start up another shell for this no-op script), but if you/upstream disagree, then feel free to close this report. In any event, the script does have an inaccurate comment at the top: # TODO: Do modern kernels handle this correctly? If so, we should detect that # and skip this hook. We know the answer, so perhaps this should be cleaned up at some point. :) -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slanga...@ubuntu.com vor...@debian.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
