tags 510153 +patch
thanks

The issue is that debian/rules calls
    $(MAKE) CFLAGS="$(CFLAGS)"
overriding the CFLAGS variable set in pkgs/tdbc1.0b1/Makefile.in, which 
had been set up to include ${SHLIB_CFLAGS} (-fPIC) by 
pkgs/tdbc1.0b1/configure (generated from the TEA_MAKE_LIB macro in 
pkgs/tdbc1.0b1/tclconfig/tcl.m4).

This is arguably an upstream bug, because CFLAGS is supposed to be 
overridable in this way, and should contain only optional optimization 
flags, not essential flags like -fPIC.

However, passing the Debian CFLAGS to configure instead of forcefully 
overriding them in make is cleaner, and allows the package to build:

diff -u tcl8.6-8.6.0~b1/debian/rules tcl8.6-8.6.0~b1/debian/rules
--- tcl8.6-8.6.0~b1/debian/rules
+++ tcl8.6-8.6.0~b1/debian/rules
@@ -43,6 +43,7 @@
        cd unix && \
          TCL_LIBRARY="/usr/share/tcltk/tcl$(v)" \
          TCL_PACKAGE_PATH="/usr/local/lib/tcltk /usr/local/share/tcltk 
/usr/lib/tcltk /usr/share/tcltk /usr/lib/tcltk/tcl$(v) /usr/lib" \
+         CFLAGS="$(CFLAGS)" \
          ./configure --host=$(DEB_HOST_GNU_TYPE) \
                      --build=$(DEB_BUILD_GNU_TYPE) \
                      --prefix=/usr \
@@ -54,7 +55,7 @@
                      --mandir=/usr/share/man \
                      --enable-man-symlinks && \
          touch ../generic/tclStubInit.c && \
-         $(MAKE) CFLAGS="$(CFLAGS)"
+         $(MAKE)
        # Build the static library.
        cd unix && \
          ar cr libtcl$(v).a *.o && \



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to