Bug#532339: vlc-plugin-jack: JACK input cannot be used with jack2

[Adrian Knoth]

Package: vlc-plugin-jack
Version: 0.9.9a-2
Severity: normal
Tags: patch

Hi!

When you try to capture from JACK, this is only possible with the 
"oldstyle" jackd-0.x. If you want to use the newer, SMP-capable jack2, 
the VLC inputs cannot be connected:

Cannot connect ports owned by inactive clients: "vlc-input-26611" is not 
active
Cannot connect ports owned by inactive clients: "vlc-input-26611" is not 
active


Unlike jack1, jack2 expects the process callback function to return 0.

The attached patch fixes this problem. It's been already fixed the same 
way in the jack output plugin (see modules/audio_output/jack.c:290).

This patch needs to be forwarded to upstream, as it isn't a debian 
specific problem.


TIA & HTH

-- System Information:
Debian Release: 5.0.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.28.7
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

diff --git a/modules/access/jack.c b/modules/access/jack.c
index 8d333aa..85c8c98 100644
--- a/modules/access/jack.c
+++ b/modules/access/jack.c
@@ -446,7 +446,7 @@ int Process( jack_nframes_t i_frames, void *p_arg )
         }
     }
 
-    return 1;
+    return 0;
 }