Ryan Niebur wrote: > here's a buildsystem class to add support for this. I would be > grateful if you would add it to the package.
Comments interspersed.
> also, while working on this I noticed in doc/PROGRAMMING it says:
> A buildsystem class needs to inherit or define these methods: DESCRIPTION,
> check_auto_buildable, build, test, install, clean.
>
> I think configure should be added to that list, yes?
Yes, done.
> package Debian::Debhelper::Buildsystem::waf;
Could you include a minimal copyright/license notice?
> sub check_auto_buildable {
> my ($this, $step) = @_;
Could you please use tabs for indentation?
> return(-e $this->get_sourcepath("waf"));
In the original bug, Trent suggested also checking for
wscript, is there any reason not to do so? Maybe ./waf should be tested
to be executable too?
waf would also need to be added to the @BUILDSYSTEMS list in
Dh_Buildsystems.pm. Safest is to add it to the end, although that would
mean you'd need --buildsystem=waf if a source package also had a stub
autoconf or Makefile.
> sub configure {
> my $this=shift;
> $this->_do_waf("configure", "--prefix=/usr/", @_);
> }
Should that perhaps be "/usr"? (As in autoconf.)
> sub test {
> my $this=shift;
> $this->_do_waf("check", @_);
> }
Is this going to quietly succeed if there is no test suite?
It needs to..
> sub clean {
> my $this=shift;
> $this->_do_waf("distclean", @_);
> $this->doit_in_sourcedir("rm", "-rf", "_build_");
_build_ is something distclean doesn't remove?
--
see shy jo
signature.asc
Description: Digital signature
