Bug#539010: libopensrs-perl: please use Digest::MD5 instead of MD5

[Ansgar Burchardt]

Package: libopensrs-perl
Version: 2.9.5-1.1
Severity: wishlist
Tags: patch

Hi,

please use the Digest::MD5 module (from the perl package) instead of the
long-deprecated MD5 module.

The attached (untested!) patch should do this.  Note that lib/CBC.pm does
not seem to be installed anyway, instead libcrypt-cbc-perl's version is
used.

I also removed the dependency on libdigest-md5-perl.  It's no longer a
real package, only provided by perl.

Regards,
Ansgar

>From 47be64d2a314067d2d986712528c7114562055ed Mon Sep 17 00:00:00 2001
From: Ansgar Burchardt <ans...@43-1.org>
Date: Tue, 28 Jul 2009 15:30:16 +0200
Subject: [PATCH] Use Digest::MD5 instead of MD5

The MD5 Perl module has been deprecated by Digest::MD5 several years
ago.
---
 debian/control |    2 +-
 lib/CBC.pm     |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/debian/control b/debian/control
index 18518dc..3307f0b 100644
--- a/debian/control
+++ b/debian/control
@@ -9,6 +9,6 @@ Package: libopensrs-perl
 Architecture: all
 Priority: optional
 Section: perl
-Depends: 
${perl:Depends},libdigest-md5-perl,libhtml-template-perl,libmd5-perl,libunicode-map-perl,libunicode-string-perl,libxml-parser-perl,libdate-manip-perl,libcrypt-blowfish-perl,libcrypt-cbc-perl,libdate-pcalc-perl,liblocale-codes-perl,libnet-libidn-perl,libdate-calc-perl
+Depends: 
${perl:Depends},libhtml-template-perl,libunicode-map-perl,libunicode-string-perl,libxml-parser-perl,libdate-manip-perl,libcrypt-blowfish-perl,libcrypt-cbc-perl,libdate-pcalc-perl,liblocale-codes-perl,libnet-libidn-perl,libdate-calc-perl
 Description: OpenSRS Perl toolkit
  The OpenSRS client Perl toolkit.
diff --git a/lib/CBC.pm b/lib/CBC.pm
index cc36d11..7c619ad 100644
--- a/lib/CBC.pm
+++ b/lib/CBC.pm
@@ -1,6 +1,6 @@
 package Crypt::CBC;
 
-use MD5;
+use Digest::MD5 'md5';
 use Carp;
 use strict;
 use vars qw($VERSION);
@@ -31,9 +31,9 @@ sub new ($$;$) {
 
     # the real key is computed from the first N bytes of the
     # MD5 hash of the provided key.
-    my $material = MD5->hash($key);
+    my $material = md5($key);
     while (length($material) < $ks + $bs)  {
-       $material .= MD5->hash($material);
+       $material .= md5($material);
     }
        
     # Original implementation of SSLEay used part of the key for the IV
-- 
1.6.3.3