Package: sbuild
Version: 0.35
Severity: normal
Tags: patch

When run with the -s option sbuild does not pass the -sa option to
dpkg-buildpackage. This results in the .orig.tar.gz file not being
included in the upload. From my understanding of the intent of -s this
is incorrect. -s is intented to force the building of a full source
package (which would include the orig.tar.gz archive iirc) even in cases
where the version number would usually result in only a binary package
being built.

Currently when using -s the generated changes file contains the deb, dsc
and diff.gz files. But *not* the orig.tar.gz file.

After applying the patch below when using -s the generated changes file
contains the deb, dsc, diff.gz and orig.tar.gz files. As I understand it
this is the correct and desired  behaviour.

The fix for this bug is very simple

--- sbuild-0.35/sbuild  2005-04-01 04:42:48.000000000 +1200
+++ sbuild-0.35crcnet0/sbuild   2005-07-13 11:34:24.000000000 +1200
@@ -737,7 +737,7 @@ EOF
        }
        if ($main::sub_pid == 0) {
                setpgrp( 0, $$ );
-               my $binopt = $main::build_source ? "" : $main::build_arch_all ? 
"-b" : "-B";
+               my $binopt = $main::build_source ? "-sa" : 
$main::build_arch_all ? "-b" : "-B";
                if ($main::chroot_dir) {
                        my $bdir = $dir;
                        $bdir =~ s/^\Q$main::chroot_dir\E//;

Hope this helps.

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.11-servers
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages sbuild depends on:
ii  adduser                3.63              Add and remove users and groups
ii  apt                    0.5.28.6          Advanced front-end for dpkg
ii  dpkg-dev               1.10.28           Package building tools for Debian
ii  exim4                  4.50-8            metapackage to ease exim MTA (v4)
ii  exim4-daemon-light [ma 4.50-8            lightweight exim MTA (v4) daemon
ii  grep-dctrl             2.1.11            Grep Debian package information
ii  perl                   5.8.4-8           Larry Wall's Practical Extraction
ii  sudo                   1.6.8p7-1.1sarge1 Provide limited super user privile

-- no debconf information

-- 
Matt Brown
[EMAIL PROTECTED]
Mob +64 275 611 544 www.mattb.net.nz





-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to