Package: dansguardian Version: 2.10.1.1-1 Severity: important Tags: patch User: [email protected] Usertags: incorrect-dependency
Hi, While examining some init scripts I found dansguardian's to be missing some dependencies. Since the binary lives in /usr it requires $remote_fs, and if the $syslog is required to be running before it is started I guess it is also required to continue running before it is stopped. Oh, and the runlevels specified on the LSB headers don't match those indicated on the update-rc.d call. http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html documents the LSB header format. Some Debian notes are available at [1] http://wiki.debian.org/LSBInitScripts Without those changes the init.d will start too early in the boot sequence on some systems. P.S. > test -f $CONFIG || exit 0 is completely useless, as $CONFIG is not defined and test will therefore always return 0. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net
diff -urpN dansguardian-2.10.1.1-1.orig/debian/dansguardian.init dansguardian-2.10.1.1-1/debian/dansguardian.init --- dansguardian-2.10.1.1-1.orig/debian/dansguardian.init 2009-08-15 21:45:42.000000000 -0500 +++ dansguardian-2.10.1.1-1/debian/dansguardian.init 2009-08-15 21:47:02.170451090 -0500 @@ -10,10 +10,10 @@ # config: /etc/dansguardian/dansguardian.conf ### BEGIN INIT INFO # Provides: dansguardian -# Required-Start: $network $syslog -# Required-Stop: $network -# Default-Start: 2 3 5 -# Default-Stop: 0 6 +# Required-Start: $remote_fs $network $syslog +# Required-Stop: $remote_fs $network $syslog +# Default-Start: 2 3 4 5 +# Default-Stop: 0 1 6 # Description: Starts dansguardian content proxy # short-description: dansguardian configuration ### END INIT INFO
