I've been looking at this bug, and from what I can see here's the problem:

The command munin-node-configure (supplied by upstream) when executed
with the --shell command line option,
goes over each available plugin from /usr/share/munin/plugins/ with
"autoconf" as the first parameter,
which basically asks each available plugin whether or not it is
capable of running on the current system.

For plugins that are able to run, a symbolic link command is printed
to STDOUT, and for plugins
that are not able to run, a shell remark is printed along with the error.

debian/munin-node.postinst is running the following command:
"munin-node-configure --shell"
and in case this command returns a non-zero exit code, it does not run
the list of symbolic link commands,
and thus no plugins are activated after munin-node package plugin.

In that case, debian/munin-node.postinst should still apply the list
of printed commands, even if some
plugins are not able to run on the system, as the output of the
plugins that can be installed is still applicable.

For example, on my system, "munin-node-configure --shell" returns the
following output:
---
ln -s /usr/share/munin/plugins/cpu /etc/munin/plugins/cpu
ln -s /usr/share/munin/plugins/entropy /etc/munin/plugins/entropy
ln -s /usr/share/munin/plugins/forks /etc/munin/plugins/forks
ln -s /usr/share/munin/plugins/if_ /etc/munin/plugins/if_eth0
# There were some errors:
# Got junk from df_inode: df: no file systems processed
# Got junk from postgres_space_: Can't locate DBI.pm in @INC (@INC
contains: /etc/perl /usr/local/lib/perl/5.10.0
/usr/local/share/perl/5.10.0 /usr/lib/perl5 /usr/share/perl5
/usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at
/usr/share/munin/plugins/postgres_space_ line 74.
# Got junk from postgres_space_: BEGIN failed--compilation aborted at
/usr/share/munin/plugins/postgres_space_ line 74.
----

Even though the command returned a non-zero exit code, this output can
still be ran as a valid shell script which activates the compatible
plugins for the system, while the ones that returned an error will be
skipped as they are commented.

As you can see, this is not a df spesific problem, I guess the bug
title should be changed to something more generic like:
"munin-node: maintainer scripts fails to create default set of enabled
plugins due to plugin autoconf error"

The only problem in fixing this is that I'm not sure what's the
correct place for the fix:
* Should munin-node-configure be patched to return an exit 0 in case
of partial errors?
* Or should debian/munin-node.postinst be changed to check if
munin-node-configure returns either
  0 (success) or 1 (partial plugins failure) and continue even if
munin-node-configure returned exit code 1?



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to