Package: libvorbis Version: 1.2.0.dfsg-6 Severity: minor Tags: upstream, patch
Dear libvorbis maintainers, I was looking at the implementation of the ov_fopen function. Currently, the implementation is: int ov_fopen(char *path,OggVorbis_File *vf) { int ret; FILE *f = fopen(path,"rb"); if(!f) return -1; ret = ov_open(f,vf,NULL,0); if(ret) fclose(f); return ret; } As can clearly be seen, char *path is used merely to open the file f. Since fopen requires only a const char * (it doesn't muck around with the path variable), ov_fopen should also have no business in modifying the path variable. Therefore, I'd request that you change the declaration of ov_fopen to: int ov_fopen(const char *path,OggVorbis_File *vf); to be more "correct" in terms of C style. Thanks. Kumar -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org