On Tue, Sep 29, 2009 at 05:14:11PM +0300, Yavor Doganov wrote:
> tags 548678 + pending
> thanks
>
> В 08:09 +0200 на 28.09.2009 (пн), Mike Hommey написа:
> > Xulrunner 1.9.1 is going to replace xulrunner 1.9 in unstable sometime
> > soonish, so kazehakase should switch to using it.
>
> Many thanks for the patch. I plan to apply it with slight
> modifications, namely:
>
> 1) Retain support for xulrunner-1.9 (not relevant for Debian, but nice
> for upstream)
>
> static const GREVersionRange greVersion = {
> "1.9.a", PR_TRUE,
> "1.9.2", PR_FALSE,
> };
Please don't. xulrunner 1.9 and 1.9.1 are not binary compatible, so a
binary built against xulrunner-1.9.1 and running with xulrunner 1.9 will
fail. If you make the GREVersionRange broader, there is non negligible
risk that people will run this kazehakase with xulrunner 1.9, and that
won't work properly.
> 2) Avoid dependency on xulrunner for the kazehakase package (I plan to
> reintroduce kazehakase-webkit with the next upload, eventually)
>
> - dh_xulrunner
> + dh_xulrunner -pkazehakase-gecko
You don't need to do that. dh_xulrunner will only add the proper dependency
if it detects it is needed.
> I'll do some tests and will hopefully upload w/i this week, provided my
> sponsor finds the time to review.
>
> One more thing... Do you plan to handle future xulrunner transitions
> with binNMUs? Kz is basically rather buggy and almost always requires
> source changes, so this approach is unlikely to work.
Well, when possible binNMU would be the best thing to do. Obviously,
with the fixed GREVersionRange, it's not possible anyways, but if a
scheme similar to that of chmsee were to be used, it would make binNMUs
possible.
Most packages that build against xulrunner 1.9 currently only require a
simple rebuild, modulo the GREVersionRange change, to fit xulrunner
1.9.1. There is hope that it might be possible for 1.9.2, too, so let's
just cross fingers. Even if binNMUs are not possible, it's still easier
to have dependencies put automatically.
Mike
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
