Package: insserv
Version: 1.12.0-11
Severity: minor
Tags: patch

(Also found in -12, -13, -14)

Thanks for keeping the insserv package description up-to-date!
Unfortunately, the new version needs some reanglification.

> Description: Tool to organize boot sequence using LSB init.d script 
> dependencies

The capital T is a regression - what was wrong with Lenny's
DevRef6.2.2-compliant "boot sequence organizer using [...]"?

> The insserv program is used to update the order of symlinks in
> /etc/rc?.d/ with sysv-rc based on dependencies specified in the
> scripts themselves using LSB init.d script headers.

I can't tell what "with sysv-rc" is intended to mean here -
• update the order of symlinks by using the package sysv-rc?
• update the order of symlinks with regard to the package sysv-rc?
• update the order of symlinks on a system with the package sysv-rc?
The best I can do in my revised version is rip it out and hope I'm
not losing anything important. 

(Incidentally, "sysv-rc" isn't the world's most self-explanatory
package name.  The "sysv" part means "a legacy of UNIX System V",
which isn't very illuminating, and "RC" doesn't stand for any of
the things a novice might guess.  In fact there's no consensus on
what the C does stand for - Change?  Control?  Configuration?)

> .
> This allow each package maintainer to specify their init.d script
> relation to other scripts and make it possible to detect and reject
> script dependency loops as well as making sure all scripts start in
> their intended order.

You've got your favourite minor grammar glitch in the second word:
you want third-person-present-singular agreement, "allowS" (likewise
later "and makeS it possible").  Then there's a missing possessive
(or similar), and I think you mean "their relationS with others".
The whole "allows X and makes Y possible as well as making sure that
Z" is a bit ungainly anyway.

My patch changes it so that it's telling end users why insserv
should be installed on their system, not giving packaging advice to
Debian developers.

> .
> The program insserv in this package should be used with care and
> together with the sysv-rc package, as using it incorrectly can lead
> to an unbootable system.

The "together with the sysv-rc package" seems to be trying to do the
job of a "Breaks: file-rc" dependency... though I suppose it's
possible to have file-rc and insserv installed together as long as
you don't run /sbin/insserv.  But the people who need to be warned
about that are people who already have file-rc plus sysv-rc and who
now get insserv pulled in during an apt-get upgrade.  Those people
won't see the warning in insserv's package description; they'll have
to depend on there being code in insserv that checks for a
compatible system and squawks if anything is wrong.

My suggested version:

 Description: boot sequence organizer using init.d script dependencies
  The insserv program is used by the standard SysV-based init system. It
  updates the order of symlinks in /etc/rc?.d/ based on dependencies
  specified by LSB headers in the init.d scripts themselves.
  .
  These declared relations between scripts make it possible to optimize
  the boot sequence for the currently installed set of packages, while
  detecting and rejecting dependency loops.
  .
  Using insserv incorrectly can result in an unbootable system.

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing'), (50, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.30.custom
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages insserv depends on:
ii  libc6                         2.9-25     GNU C Library: Shared libraries

insserv recommends no packages.

Versions of packages insserv suggests:
ii  bootchart                0.10~svn407-3.1 Boot process performance analyser

-- debconf information:
* insserv/enable: true

-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
diff -ru insserv-1.12.0.pristine/debian/control insserv-1.12.0/debian/control
--- insserv-1.12.0.pristine/debian/control	2009-10-01 16:50:56.000000000 +0100
+++ insserv-1.12.0/debian/control	2009-10-02 14:33:32.000000000 +0100
@@ -15,16 +15,13 @@
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Suggests: bootchart
 Breaks: sysv-rc (<< 2.87dsf-3)
-Description: Tool to organize boot sequence using LSB init.d script dependencies
- The insserv program is used to update the order of symlinks in
- /etc/rc?.d/ with sysv-rc based on dependencies specified in the
- scripts themselves using LSB init.d script headers.
+Description: boot sequence organizer using LSB init.d script dependencies
+ The insserv program is used by the standard SysV-based init system. It
+ updates the order of symlinks in /etc/rc?.d/ based on dependencies
+ specified by LSB headers in the init.d scripts themselves.
  .
- This allow each package maintainer to specify their init.d script
- relation to other scripts and make it possible to detect and reject
- script dependency loops as well as making sure all scripts start in
- their intended order.
+ These declared relations between scripts make it possible to optimize
+ the boot sequence for the currently installed set of packages, while
+ detecting and rejecting dependency loops.
  .
- The program insserv in this package should be used with care and
- together with the sysv-rc package, as using it incorrectly can lead
- to an unbootable system.
+ Using insserv incorrectly can result in an unbootable system.

Reply via email to