Bug#551007: please add ripemd160 digest to libnet-ssleay-perl

[Daniel Kahn Gillmor]

Package: libnet-ssleay-perl
Tags: patch
Severity: wishlist

hey good folks behind Net::SSLeay in debian--

there's currently no good ripemd160 implementation available in perl in
debian that i know of (and Crypt::RIPEMD160 has dubious licensing
issues).  For various reasons, it'd be nice to be able to calculate
RIPEMD160 digests in perl.

libnet-ssleay already exports MD2, MD4, and MD5 from OpenSSL.  It's
pretty straightforward to extend this to include RIPEMD160.

I've attached a patch that WorksForMe™, including test cases and a note
in the QuickRef documentation.  I'd be happy for review (and inclusion
upstream, if there's any interest -- it's licensed under the same terms
as Net::SSLeay itself, if you feel that's relevant).

Also, i'm part of the pkg-perl group, so i believe i actually have
commit access.  So I could commit this change myself, but i'd rather
make sure that other folks are OK with it before i blunder ahead.

Any suggestions for or objections to this patch?

Thanks,

        --dkg

diff -ruN libnet-ssleay-perl-1.35/QuickRef libnet-ssleay-perl-1.35.dkg/QuickRef
--- libnet-ssleay-perl-1.35/QuickRef	2008-07-23 21:03:22.000000000 -0400
+++ libnet-ssleay-perl-1.35.dkg/QuickRef	2009-10-13 18:05:58.000000000 -0400
@@ -182,12 +182,15 @@
 
 
 #----------------------
-# MD5 - hashfunction
+# MD2, MD4, MD5, RIPEMD160 - hash functions
 #----------------------
 
 $hash = Net::SSLeay:MD5($data);
 	Computes md5 hash over $data. $hash is a binary string! Convert it to
 	a printable with $string = unpack("H32",Net::SSLeay::MD5($data));
+$hash = Net::SSLeay:RIPEMD160($data);
+	Computes RIPEMD160 hash over $data. $hash is a binary string! Convert it to
+	a printable with $string = unpack("H40",Net::SSLeay::RIPEMD160($data));
 
 
 #----------------------
diff -ruN libnet-ssleay-perl-1.35/SSLeay.xs libnet-ssleay-perl-1.35.dkg/SSLeay.xs
--- libnet-ssleay-perl-1.35/SSLeay.xs	2008-07-23 21:03:22.000000000 -0400
+++ libnet-ssleay-perl-1.35.dkg/SSLeay.xs	2009-10-13 16:34:05.000000000 -0400
@@ -98,6 +98,7 @@
 #include <openssl/md2.h>
 #include <openssl/md4.h>
 #include <openssl/md5.h>     /* openssl-SNAP-20020227 does not automatically include this */
+#include <openssl/ripemd.h>
 #include <openssl/x509.h>
 #include <openssl/x509v3.h>
 #include <openssl/engine.h>
@@ -1777,6 +1778,22 @@
 	  XSRETURN_UNDEF;
      }
 
+void 
+RIPEMD160(data)
+     PREINIT:
+     STRLEN len;
+     unsigned char md[RIPEMD160_DIGEST_LENGTH];
+     unsigned char * ret;
+     INPUT:
+     unsigned char *  data = (unsigned char *) SvPV( ST(0), len);
+     CODE:
+     ret = RIPEMD160(data,len,md);
+     if (ret!=NULL) {
+	  XSRETURN_PVN((char *) md, RIPEMD160_DIGEST_LENGTH);
+     } else {
+	  XSRETURN_UNDEF;
+     }
+
 SSL_METHOD *
 SSLv2_method()
 
diff -ruN libnet-ssleay-perl-1.35/t/local/50_digest.t libnet-ssleay-perl-1.35.dkg/t/local/50_digest.t
--- libnet-ssleay-perl-1.35/t/local/50_digest.t	2007-10-16 04:26:45.000000000 -0400
+++ libnet-ssleay-perl-1.35.dkg/t/local/50_digest.t	2009-10-13 16:43:33.000000000 -0400
@@ -10,48 +10,57 @@
             md2 => '8350e5a3e24c153df2275c9f80692773',
             md4 => '31d6cfe0d16ae931b73c59d7e0c089c0',
             md5 => 'd41d8cd98f00b204e9800998ecf8427e',
+            ripemd160 => '9c1185a5c5e9fc54612808977ee8f548b2258d31',
         },
         'a' => {
             md2 => '32ec01ec4a6dac72c0ab96fb34c0b5d1',
             md4 => 'bde52cb31de33e46245e05fbdbd6fb24',
             md5 => '0cc175b9c0f1b6a831c399e269772661',
+            ripemd160 => '0bdc9d2d256b3ee9daae347be6f4dc835a467ffe',
         },
         '38' => {
             md2 => '4b85c826321a5ce87db408c908d0709e',
             md4 => 'ae9c7ebfb68ea795483d270f5934b71d',
             md5 => 'a5771bce93e200c36f7cd9dfd0e5deaa',
+            ripemd160 => '6b2d075b1cd34cd1c3e43a995f110c55649dad0e', # guessed at this, since it wasn't present in the tables at http://homes.esat.kuleuven.be/~bosselae/ripemd160.html
         },
         'abc' => {
             md2 => 'da853b0d3f88d99b30283a69e6ded6bb',
             md4 => 'a448017aaf21d8525fc10ae87aa6729d',
             md5 => '900150983cd24fb0d6963f7d28e17f72',
+            ripemd160 => '8eb208f7e05d987a9b044a8e98c6b087f15a0bfc',
         },
         'message digest' => {
             md2 => 'ab4f496bfb2a530b219ff33031fe06b0',
             md4 => 'd9130a8164549fe818874806e1c7014b',
             md5 => 'f96b697d7cb7938d525a2f31aaf161d0',
+            ripemd160 => '5d0689ef49d2fae572b881b123a85ffa21595f36',
         },
         'abcdefghijklmnopqrstuvwxyz' => {
             md2 => '4e8ddff3650292ab5a4108c3aa47940b',
             md4 => 'd79e1c308aa5bbcdeea8ed63df412da9',
             md5 => 'c3fcd3d76192e4007dfb496cca67e13b',
+            ripemd160 => 'f71c27109c692c1b56bbdceb5b9d2865b3708dbc',
         },
         'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789' => {
             md2 => 'da33def2a42df13975352846c30338cd',
             md4 => '043f8582f241db351ce627e153e7f0e4',
             md5 => 'd174ab98d277d9f5a5611c2c9f419d9f',
+            ripemd160 => 'b0e20b6e3116640286ed3a87a5713079b21f5189',
         },
         '12345678901234567890123456789012345678901234567890123456789012345678901234567890' => {
             md2 => 'd5976f79d83d3a0dc9806c3c66f3efd8',
             md4 => 'e33b4ddc9c38f2199c3e7b164fcc0536',
             md5 => '57edf4a22be3c955ac49da2e2107b67a',
+            ripemd160 => '9b752e45573d4b39f4dbd3323cab82bf63326bfb',
         },
 );
 
-plan tests => (keys %fps) * 3;
+plan tests => (keys %fps) * 4;
 
 for my $data (sort keys %fps) {
     is(unpack('H32', Net::SSLeay::MD2($data)), $fps{$data}->{md2}, "MD2 hash for '$data'");
     is(unpack('H32', Net::SSLeay::MD4($data)), $fps{$data}->{md4}, "MD4 hash for '$data'");
     is(unpack('H32', Net::SSLeay::MD5($data)), $fps{$data}->{md5}, "MD5 hash for '$data'");
+    is(unpack('H40', Net::SSLeay::RIPEMD160($data)), $fps{$data}->{ripemd160}, "RIPEMD160 hash for '$data'");
 }

signature.asc
Description: OpenPGP digital signature