On Wed, Oct 28, 2009 at 04:28:49PM +0000, Niall Walsh wrote: > Package: nbd-client > Version: 1:2.9.14-1 > Severity: wishlist > Tags: patch > > Hi again, > > in a "live" busybox+klibc based initramfs the sed function to extract the > port from the 3 argument form of nbdroot fails. The parts of the regex work > but the total regexp fails to do anything, I didn't really dig into the > source of that issue as it seemed like it was likely to be a limitation of > the particular sed.
Sigh. I wish there weren't so many incompatibly incomplete sed implementations out there. Oh well. > I'm hoping you would consider rewriting this to make it > less likely to break in less competent implementations of sed. > > I have attached a patch which eliminates sed completely by using more shell > substitutions, though just breaking down that one more complicated sed > expression to two seperate calls to sed works equally well for me in my > environment so tmtowtdi. If shell substitutions work, that's always faster, so taking that (I didn't even know you could do these things with shell substitutions. Thanks) > It's worth noting that a kernel root option will set the nbd device which is > what is additionally set in the 3 argument form of nbdroot anyway, so again I > might only have tripped this as I'm not using initramfs-tools local with a > normal rootfs so I don't want to set root on the kernel command line. You do need to set your root device /somehow/, of course. I don't know whether the live-initramfs will go and look for something that looks like a root device that it can boot off of(it might); but on a normal installation, you'd have to supply a root= argument anyway. I did the three-argument form of nbdrootdev only because you might be running something batshit insane like root-on-lvm-on-NBD, which would require you to have a root= parameter that does not mention the particular /dev/nbdX device you want to be running on. At any rate, your patch looks sane, so I'll by applying it (together with the other patch you sent) -- The biometric identification system at the gates of the CIA headquarters works because there's a guard with a large gun making sure no one is trying to fool the system. http://www.schneier.com/blog/archives/2009/01/biometrics.html -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
