On 2009-10-15 07:07, Philip Hands wrote: : Would you care to comment on this bug: : : http://bugs.debian.org/543362 : : It seems to make sense to me, but it's not immediately obvious to me : what one might do to fix it, as the parent might not have a window : (since it's running from .xsession, say).
Hi, Phil. Thanks for alerting me to this. I (rather obviously) haven't done much with x11-ssh-askpass for quite some time. However, I seem to recall that setting the WM_TRANSIENT_FOR property was necessary to explain to window managers such as Window Maker that the x11-ssh-askpass window was not an application window but rather a ... well, transient dialog window. I think that Dave Harding's reading of section 4.1.2.6 is overly strict. I think it rather obvious that (1) x11-ssh-askpass is not an application, but a dialog window, and that acting as its own parent is appropriate; and that (2) alternatives such as gnome-ssh-askpass have the ability to set other, GNOME-specific (or, more recently, freedesktop.org-specific) hints about its function and decoration, eliminating the need for WM_TRANSIENT_FOR altogether. I don't really remember whether, at the time i wrote x11-ssh-askpass, i actually found other applications that used WM_TRANSIENT_FOR the same way, or whether i merely read of it somewhere. However, i can't imagine that i actually invented the technique ... i'm not that smart. :) I suppose it could be argued that the root window of the screen displaying x11-ssh-askpass, or the root window of screen 0, should (or could) be listed as the parent in the WM_TRANSIENT_FOR property. I don't know whether that would work, either for Awesome or for Window Maker or any other window manager. I'm not really in a position to develop x11-ssh-askpass further and try that out. In my opinion, a somewhat loose interpretation of the function of WM_TRANSIENT_FOR is a much better solution than using OVERRIDE_REDIRECT, which is what many similar dialog-based programs (ab)used at the time of x11-ssh-askpass's genesis. And, as Dave admits, Awesome should be fixed; infinite loops looking for a transient window's parent are fairly brittle behavior. Best, Jim -- jim knoble | [email protected] | http://www.pobox.com/~jmknoble/ (GnuPG key ID: C6F31FFA >>>>>> http://www.pobox.com/~jmknoble/keys/ ) (GnuPG fingerprint: 99D8:1D89:8C66:08B5:5C34::5527:A543:8C33:C6F3:1FFA) -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
