Hi,

The proposed patch didn't really work.

Here's a patch that works as intended, this means preventing ANY popup
errors from showing.

Upstream has made several changes to how this function works: stopping
the program from generating infinite dialogs, not showing a dialog if
the printer is paused, and other stuff like that.

The amount of changes needed to apply these updates to the current
code in stable were too many for my taste.  Also, even with the many
fixes applied, it still doesn't take into account the username (it
shows the message to all users of the computer, regardless of who
created the print job) and it seems (I didn't really test it) that
once you close the window acknowledging the problem, it will show up
again (so, not infinite windows, but one very annoying window).

My feeling is that this program is VERY low quality, the new upstream
release might be better, but it still needs a lot of work to be of
Debian quality.

-- 
Besos,
Marga
--- system-config-printer-1.0.0.orig/jobviewer.py	2008-05-27 12:42:10.000000000 -0300
+++ system-config-printer-1.0.0/jobviewer.py	2009-12-14 12:43:27.000000000 -0300
@@ -33,7 +33,7 @@
 import sys
 import time
 
-from debug import *
+from cupsutils.debug import *
 import config
 import statereason
 import errordialogs
@@ -847,6 +847,9 @@
                 # Leave this to update_job to deal with.
                 pass
             else:
+                # DON'T NAG THE USER
+                pass
+
                 # Other than that, unfortunately the only
                 # clue we get is the notify-text, which is not
                 # translated into our native language.  We'd better
@@ -863,7 +866,7 @@
                 # error_log file for details."
                 #
                 # "Authentication is required for job %d."
-                notify_text = event['notify-text']
+                """notify_text = event['notify-text']
                 document = jobdata['job-name']
                 if notify_text.find ("backend errors") != -1:
                     message = _("There was a problem sending document `%s' "
@@ -913,7 +916,7 @@
                 hbox.pack_start (vbox, False, False, 0)
                 dialog.vbox.pack_start (hbox)
                 dialog.connect ('response', self.print_error_dialog_response)
-                dialog.show_all ()
+                dialog.show_all ()"""
 
         self.update_job (jobid, jobdata)
 

Reply via email to