Package: git-buildpackage
Version: 0.4.62
Severity: normal

Hi,

I've been bit by a nasty and subtle bug yesterday when using
--git-export=WC in the same checkout for multiple versions of my
packaged software.

I'll get straight down to the cause of the bug. When --git-export=WC is
given, the function write_wc in git-buildpackage creates a tree object
by adding all files in the working copy to the index. To prevent messing
up the current index, it sets GIT_INDEX_FILE to .git/gbp_index. However,
no effort is made to clean up this index file, either before or
afterwards. This means that if I have files in my working copy, I run
git-buildpackage with --git-export=WC, remove the files and run it
again, these files will still be in the exported build dir.

I'm not sure if the index file is still needed after write_wc is done,
but perhaps the file can simply be removed afterwards? Alternatively,
a git rm -r --cached . before the git add -f . could be more robust.
Even more pretty would probably be to remove the file afterwards, but
also check that it doesn't exist yet beforehand (and error out if it
does).

Gr.

Matthijs

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-rc8 (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages git-buildpackage depends on:
ii  devscripts                   2.10.59     scripts to make the life of a Debi
ii  git-core                     1:1.6.5.4-1 fast, scalable, distributed revisi
ii  python                       2.5.4-4     An interactive high-level object-o
ii  python-dateutil              1.4.1-3     powerful extensions to the standar
ii  python-support               1.0.6       automated rebuilding support for P

Versions of packages git-buildpackage recommends:
ii  pristine-tar                  1.00       regenerate pristine tarballs

Versions of packages git-buildpackage suggests:
pn  git-load-dirs                 <none>     (no description available)

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to